Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add graphql to supported languages #3444

Closed
wants to merge 4 commits into from
Closed

Conversation

jf990
Copy link
Contributor

@jf990 jf990 commented Dec 30, 2021

Add graphql to supported languages

Related to v11 update jf990/highlightjs-graphql#1

Changes

Include graphql in SUPPORTED_LANGUAGES.md

Checklist

  • Added markup tests, verified language detection didn't break
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Would you be interested in seeing GraphQL in Core? If so I may be willing to add it seeing:

  • the overall simplicity of grammar
  • popularity of GraphQL as a key web technology today

If so, would you also be interested in being it's language champion?

This is along the lines of the same justification I used for adding WebAssembly in that it's pervasiveness on the web makes it too relevant not to include by default.

Thoughts?

@jf990
Copy link
Contributor Author

jf990 commented Dec 30, 2021

@joshgoebel sounds like a great idea to me, I will close this PR and redo it as a core contribution.

I expect to remain the primary responsibility for the grammars I've contributed so I will continue in this role.

@jf990
Copy link
Contributor Author

jf990 commented Dec 30, 2021

Closing PR and redoing as a core language

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants