-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Proper highlighting for the Wolfram Language (Mathematica) #2706
Merged
joshgoebel
merged 32 commits into
highlightjs:master
from
halirutan:WIP_Wolfram_Language
Nov 6, 2020
Merged
Changes from 18 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
75dc896
Add first try for proper highlighting for the Wolfram Language
halirutan 1b5a3ae
Include keywords as list, break up regexes, add features
halirutan 2c01097
Disable autodetect for Mathematica until I have a good idea how this …
halirutan b78e9fc
Merge branch 'master' into WIP_Wolfram_Language
halirutan 6216916
Merge remote-tracking branch 'upstream/master' into WIP_Wolfram_Language
halirutan 0437cd8
Merge remote-tracking branch 'origin/WIP_Wolfram_Language' into WIP_W…
halirutan 8d61d15
Improve things Josh suggested
halirutan 165ea9d
Improve things Josh suggested
halirutan 9cc315e
Merge branch 'master' into WIP_Wolfram_Language
halirutan 7e7262d
Merge branch 'test_rule_improvements' into WIP_Wolfram_Language
halirutan 050cad2
Make more general for going into core HLJS.
halirutan 15d4251
Introduce specific class-names and use alias table.
halirutan ae6e1e3
Update src/languages/mathematica.js
halirutan 3ee0fd0
Update src/languages/mathematica.js
halirutan 95e1d91
Update src/languages/mathematica.js
halirutan b869c93
Update src/languages/mathematica.js
halirutan 2648bd1
Small changes regarding relevance and position of comment rules.
halirutan 47ed49e
first pass as classNameAliases and docs
joshgoebel 5c02def
separate symbol rules
joshgoebel b06b5ce
add missing escape for UTF-8 compat
joshgoebel 33fbc4d
proper type
joshgoebel 7f43954
declare better type info for on:begin
joshgoebel 1fa1040
we need a naked object
joshgoebel 67ceb03
just use ModeCallback, duh
joshgoebel 92b413a
Remove trailing commas
halirutan c4838b6
final cleanups
joshgoebel ad71815
Merge branch 'WIP_Wolfram_Language' of github.com:halirutan/highlight…
joshgoebel 0653dcd
classNameAliases needs to be a null object to avoid `constructor` issues
joshgoebel a178a71
Merge branch 'master' into WIP_Wolfram_Language
joshgoebel 6d240a7
Add change-log for Mathemtica and put myself into the champions-club
halirutan c20aa2a
tweak changelog
joshgoebel 5d2d68a
Merge branch 'master' into WIP_Wolfram_Language
joshgoebel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allejo Any thoughts on this naming? It seems clear to me... Other ideas were nesting, but that seems more complex:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be fine with
classNameAliases
. Another suggestion would bestyleClassAliases
(or evenstyleAliases
) which makes it a bit clearer what we're talking about. You should decide this having the newbie user in mind.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className
has meaning though because it's the key we use to specify such things already... making className and classNameAliases consistent.