-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove two Dentons proxies #316
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove two Dentons proxies
2 tasks
Kudos, SonarCloud Quality Gate passed! |
SimiHunjan
approved these changes
Nov 13, 2023
RickyLB
approved these changes
Nov 13, 2023
2 tasks
andrewb1269hg
added a commit
that referenced
this pull request
Oct 29, 2024
commit 0170d28 Resolve Comments commit 028a72b Rename hedera to Hedera and spec out TransactionBuilder commit 0414bf4 Bring ContractUpdate to parity commit 0444b3b Use unnamed arguements for single parameter functions commit 049d16a Sign transaction commit 05071c5 Cleanup QueryBuilder and fix some swiftlints commit 070ef99 Add AccountRecordsQuery commit 0724401 Add helper methods to TransactionBuilder and move operator sign step to TransactionBuilder.build commit 07b5a2f Fix nits commit 07f2e51 Add `Id` to the end of function names that take and id as a first parameter, for parity! commit 0a31d43 feat(HIP-540): change or remove existing keys from tokens commit 0aa65f8 Fix `.setMaxQueryPayment` comment commit 0b8bffe Remove transaction based helpers from Client commit 0ce344e Bring AccountUpdate and AccountDelete to parity commit 0f386e1 Rename ProtobufConvertible to ProtoConvertible commit 10443db chore(deps): bump step-security/harden-runner from 2.9.1 to 2.10.1 commit 10a8ada Add AccountCreateTransaction commit 11dbe39 Fix Dockerfile: bind user and ignore files commit 1355040 ci: 335 update ci workflows for best practices and standards commit 14e3a48 Make TransactionBuilder.build() more correct commit 158608b Purge Claims commit 164bf04 Bump year for LICENSE commit 16e4d91 feat: Add remaining examples (#83) commit 17f0d37 Change throwing functions to not throw and instead return a Result commit 1852c16 Bring TransactionBuilder closer to parity commit 1b9229f Update Contract*Transactions to be more idiomatic commit 1cdae00 Update swift grpc to 1.0 alpha commit 1e908ce Remove two Dentons proxies (#316) commit 1f73ffc Fix: multi-chunked transactions contain the same payer account id (#325) commit 1f85647 Refactor TransactionBuilder.executeClosure to be a switch statement in Transaction commit 21f11a1 More tests (#274) commit 232c312 Initial commit commit 24840e7 Add AccountUpdateTransaction and AccountDeleteTransaction commit 257009b Implement Contract*Transaction commit 257d728 WIP: CallParams part 1 commit 2580f23 chore(deps): bump actions/cache from 4.0.2 to 4.1.1 commit 25860f1 Update .gitlab-ci.yml commit 2879677 Use exponential backoff for QueryBuilder#execute while making sure that Receipt and Record queries additionally retry on OK and UNKNOWN response codes commit 29c01b6 Even more parity changes commit 2a2dfdf Add some vscode setup files and remove example code from compilation commit 2b8eb59 Update x.py to build or test commit 2b9aded Ignore case statements for cyclomatic complexity rule in swiftlint commit 2cacb2a Add documentation for Contract*Transaction methods commit 2f16415 Add Ed25519 private and public key structs commit 321b71f Initial attempt at implementing execute() for Transaction commit 322a065 Create Account example is almost complete commit 33637cf Implement sign and verify for ed25519 commit 33997b8 Add AccountDeleteClaimTransaction commit 346f855 feat(hip-869): added DAB Node operations commit 3671ae3 First draft of dockerfile for consistent and reliable linux compilation commit 371a135 Bring several crypto things closer to parity commit 3772ea9 add some unit tests (#160) commit 3bf274c chore: update and properly constrain secp256k1 (#128) commit 3c4de74 chore(deps): bump step-security/harden-runner from 2.9.0 to 2.9.1 (#367) commit 3c5013f Initialize `FunctionResult` from proto version commit 3cb2cb1 Make examples build again commit 3d83abf Feat/chore: add more examples (#77) commit 3e5da59 Resolve Comments commit 3f3f0ed WIP: QueryBuilder commit 40bc68e Add ContractGetRecordsQuery commit 42d6aaa Fix Examples commit 4392e0d Update .gitlab-ci.yml commit 4524b6d Update readme commit 461e56f Bring ContractDelete to parity commit 469f11f Token Reject Flow commit 47ee636 feat(tck): add TCK server (#344) commit 47f3edc Add remaining transaction requirements (#76) commit 4836492 Clean up crypto commit 485fec9 Attempt to fix ci commit 48fdb78 Add Unit Tests (#295) commit 4a4fe88 Respect the transaction's node choice commit 4d5f678 chore: Document everything (to a certain degree) (#75) commit 4e59f0d Bring CryptoTransfer to parity commit 4ee2dbe refactor: Make TopicMessage match other SDKs (#74) commit 50c409a fix: ensure transaction.toBytes signs the sources if they exist (#82) commit 5150ce3 refactor client usage commit 53a8b12 chore: more examples (#78) commit 54982ac TransactionRecordQuery commit 5664aa2 Fix QueryBuilder commit 566a576 Implement Queries commit 5818046 ci: add ci (#45) commit 587d68e Implement SDK Wrappers commit 58ed232 Add LICENSE commit 5941360 Make Client compile again and add getAccountInfo commit 5b160d8 fix: upgrade swift_numberkit and remove UInt64 casts commit 5c95d6f Implement File*Transaction commit 5e03799 Bring AccountCreateTransaction to parity commit 5e30f7f Swiftlint commit 5e6b6c1 Big changes, the CreateAccountExample is now runnable but it throws an error commit 62a272e Make it possible to manually construct a ThresholdKey commit 6500d03 HIP-904: Allow autoMaxTokenAssociation to accept -1 & TokenReject commit 68767cd Use more idiomatic Swift styling commit 68e9073 Update README to template commit 6c57705 feat(HIP-844): add signer nonce commit 6c78eff chore(deps): bump step-security/harden-runner from 2.8.1 to 2.9.0 commit 70022f4 Remove Dockerfile; no longer needed commit 71e0246 Add various E2E tests (#100) commit 731fe4a Remove some cruft commit 7564cfa Refactor Ed25519PrivateKey to store the whole keypair instead of just the private key bytes commit 7616c19 Clean up and future-atize the execute method in QueryBuilder commit 76ae41f feat(client): various client stuff (#96) commit 7a9c6fc WIP: CallParams part 2 commit 7e7dd3f Refactor a large pile of stuff - determining which grpc method to call is now Transaction's job - Client is now nullable in TransactionBuilder and Transaction (a couple places still need adjusting) - Add (currently failing) serialization test for AccountCreateTransaction commit 80047d5 e2e test: TokenPauseTransaction (#299) commit 8200a1b chore(deps): bump github.com/apple/swift-nio-http2 from 1.27.0 to 1.28.1 commit 85a9362 Remove FunctionResult as it was based on an old broken version of the JS SDK commit 89d96b5 Airdrop functionality commit 8b2484a Improve hexDecode to not break on non-hex characters commit 8bf7c03 Bring FileUpdate to parity commit 8cf41ad Future-atize execute on Transaction and fix minor bug in similar code for QueryBuilder commit 91907c3 feat: add metadata field for tokens commit 92ee2a2 feat: Implement JSON-RPC endpoint for `AccountCreateTransaction` commit 953da17 TransactionReceiptQuery and Transaction.executeForReceipt() commit 957a7a1 Bring FileCreate to parity commit 9580a78 WIP commit 96aa5f7 Add doc comments for Client transactions/queries commit 97a4fc0 Bring QueryBuilder closer to parity commit 98a4481 Fix formatting commit 99527cf WIP commit 9968261 More parity changes commit 99fb3ea Helper Client Methods commit 9a8dc3f Move HederaError to its own file commit 9d28a42 Update x.py to allow dynamic operands commit a0b7365 Add Claim to AccountInfo & add CryptoGetClaimQuery commit a1716ca Implement ContractLogInfo commit a17d3cb chore(deps): bump step-security/harden-runner from 2.7.0 to 2.7.1 (#338) commit a2e1ca3 feat: Add DelegateContractId (#79) commit a60578d Add documentation for File*Transaction methods commit a783e31 Resolve Comments commit aa015b3 fix: Fix a couple of major bugs in execute logic (#98) commit ad64797 Bring ContractCreate to parity commit b192b07 Fix account create test commit b38efae more E2E tests (#138) commit b396dfb Add more flexibility to AccountId's initializers commit b3ff7ca Add AccountId commit b4ebdc3 Pipe stderr to stdout using bash &2>1 commit b5e15aa Add CreateFileExample commit b6947a6 chore(deps): bump actions/checkout from 4.1.1 to 4.1.5 (#339) commit b74df5e Refactor AccountId/ContractId/FileId to be typealiases of EntityId commit b7b3d5a Implement TransactionRecord SDK Wrapper commit bb7a590 Add typealiases for a couple closures commit bd23087 GRPC has to be insecure to work with Hedera commit be5dd94 Add FunctionResult commit beac23d Remove Dentons proxy from Network+Config.swift (#321) commit beb008d Add grpc protos commit bf6d9f4 Bring the entity ids closer to parity commit c0c9ed1 Bump deps (protobufs are deps) (#81) commit c2f4eb0 Implement ContractCallLocalQuery commit c60a136 Use exponential backoff for Transaction#execute commit c82bc1f ci: Try enabling swift ~5.6~ and 5.8 (#84) commit c8392c3 Add TransferCrypto Example commit c882bd0 Bring FileAppend to parity commit c8d5f76 Implement Hbar type commit cc48cd5 CI commit d16304f Minor tweaks to error messages commit d17d3b7 Bring this sdk closer to parity commit d6b8fb8 Update README.md commit d7a193c feat(transaction): getSignatures (#309) commit dda721d Implement PublicKey class, subclass with Ed25519PublicKey, KeyList, ThresholdKey, and ContractId Needed to refactor the entity ids to make this work in exchange for repeated code... commit e02286a Make examples take parameters from the environment commit e0d6576 docs: update usage example in README, show how to depend on dep commit e15c798 chore(deps): bump swift-actions/setup-swift from 2.0.0 to 2.1.0 commit e1d8d9d Add queryReceiptAsync, queryRecord, and queryRecordAsync to Transaction Remove executeForReceipt from Transaction and TransactionBuilder commit e259ef5 chore: document behavior of `expectedDecimals` (#141) commit e5a4845 Add setHeader to QueryBuilder commit e79038b More unit tests (#313) commit ebb7386 Add missing function for AccountAddClaimTransaction commit ec5b533 Remove Hex.swift and use Sodium's hex decoding functions instead commit ef0d3ac Remove x.py; no longer needed commit f105126 chore: run local node in e2e tests (#318) commit f198de4 fix(AccountCreateTransaction): evmAddress is actually alias (#97) commit f346164 Bring FileDelete to parity commit f438e74 Make CreateAccountTransactionTest pass, even though it's not fully identical to Java commit f77ae28 Refactor Transaction to make it have to reconstruct things less while avoiding making it store much more commit f941dd7 Get rid of most TODOs commit f9f0938 WIP commit f9fc8f2 Start filling in TransactionBuilder and Transaction functionality Signed-off-by: Andrew Brandt <[email protected]>
rbarkerSL
added a commit
that referenced
this pull request
Jan 23, 2025
commit 0170d28 Resolve Comments commit 028a72b Rename hedera to Hedera and spec out TransactionBuilder commit 0414bf4 Bring ContractUpdate to parity commit 0444b3b Use unnamed arguements for single parameter functions commit 049d16a Sign transaction commit 05071c5 Cleanup QueryBuilder and fix some swiftlints commit 070ef99 Add AccountRecordsQuery commit 0724401 Add helper methods to TransactionBuilder and move operator sign step to TransactionBuilder.build commit 07b5a2f Fix nits commit 07f2e51 Add `Id` to the end of function names that take and id as a first parameter, for parity! commit 0a31d43 feat(HIP-540): change or remove existing keys from tokens commit 0aa65f8 Fix `.setMaxQueryPayment` comment commit 0b8bffe Remove transaction based helpers from Client commit 0c86a2e Use OpenSSL for keccak256 encryption commit 0ce344e Bring AccountUpdate and AccountDelete to parity commit 0f386e1 Rename ProtobufConvertible to ProtoConvertible commit 10443db chore(deps): bump step-security/harden-runner from 2.9.1 to 2.10.1 commit 10a8ada Add AccountCreateTransaction commit 11dbe39 Fix Dockerfile: bind user and ignore files commit 1355040 ci: 335 update ci workflows for best practices and standards commit 14e3a48 Make TransactionBuilder.build() more correct commit 158608b Purge Claims commit 164bf04 Bump year for LICENSE commit 16e4d91 feat: Add remaining examples (#83) commit 17f0d37 Change throwing functions to not throw and instead return a Result commit 1852c16 Bring TransactionBuilder closer to parity commit 1b9229f Update Contract*Transactions to be more idiomatic commit 1cdae00 Update swift grpc to 1.0 alpha commit 1e908ce Remove two Dentons proxies (#316) commit 1f73ffc Fix: multi-chunked transactions contain the same payer account id (#325) commit 1f85647 Refactor TransactionBuilder.executeClosure to be a switch statement in Transaction commit 21f11a1 More tests (#274) commit 232c312 Initial commit commit 24840e7 Add AccountUpdateTransaction and AccountDeleteTransaction commit 257009b Implement Contract*Transaction commit 257d728 WIP: CallParams part 1 commit 2580f23 chore(deps): bump actions/cache from 4.0.2 to 4.1.1 commit 25860f1 Update .gitlab-ci.yml commit 2879677 Use exponential backoff for QueryBuilder#execute while making sure that Receipt and Record queries additionally retry on OK and UNKNOWN response codes commit 29c01b6 Even more parity changes commit 2a2dfdf Add some vscode setup files and remove example code from compilation commit 2b8eb59 Update x.py to build or test commit 2b9aded Ignore case statements for cyclomatic complexity rule in swiftlint commit 2cacb2a Add documentation for Contract*Transaction methods commit 2f16415 Add Ed25519 private and public key structs commit 321b71f Initial attempt at implementing execute() for Transaction commit 322a065 Create Account example is almost complete commit 33637cf Implement sign and verify for ed25519 commit 33997b8 Add AccountDeleteClaimTransaction commit 346f855 feat(hip-869): added DAB Node operations commit 3671ae3 First draft of dockerfile for consistent and reliable linux compilation commit 371a135 Bring several crypto things closer to parity commit 3772ea9 add some unit tests (#160) commit 3bf274c chore: update and properly constrain secp256k1 (#128) commit 3c4de74 chore(deps): bump step-security/harden-runner from 2.9.0 to 2.9.1 (#367) commit 3c5013f Initialize `FunctionResult` from proto version commit 3cb2cb1 Make examples build again commit 3d83abf Feat/chore: add more examples (#77) commit 3e5da59 Resolve Comments commit 3f3f0ed WIP: QueryBuilder commit 40bc68e Add ContractGetRecordsQuery commit 42d6aaa Fix Examples commit 4306f10 Add E2E: NodeCreateTransaction w/ Solo commit 4392e0d Update .gitlab-ci.yml commit 4524b6d Update readme commit 461e56f Bring ContractDelete to parity commit 469f11f Token Reject Flow commit 47ee636 feat(tck): add TCK server (#344) commit 47f3edc Add remaining transaction requirements (#76) commit 4836492 Clean up crypto commit 485fec9 Attempt to fix ci commit 48fdb78 Add Unit Tests (#295) commit 4a4fe88 Respect the transaction's node choice commit 4b445d3 `HIP-432`: Long Term Scheduled Transaction commit 4d5f678 chore: Document everything (to a certain degree) (#75) commit 4e59f0d Bring CryptoTransfer to parity commit 4ee2dbe refactor: Make TopicMessage match other SDKs (#74) commit 50c409a fix: ensure transaction.toBytes signs the sources if they exist (#82) commit 5150ce3 refactor client usage commit 53a8b12 chore: more examples (#78) commit 53ccd28 chore(deps): bump step-security/harden-runner from 2.10.1 to 2.10.2 (#410) commit 54982ac TransactionRecordQuery commit 5664aa2 Fix QueryBuilder commit 566a576 Implement Queries commit 5818046 ci: add ci (#45) commit 587d68e Implement SDK Wrappers commit 58ed232 Add LICENSE commit 5941360 Make Client compile again and add getAccountInfo commit 5b160d8 fix: upgrade swift_numberkit and remove UInt64 casts commit 5c95d6f Implement File*Transaction commit 5e03799 Bring AccountCreateTransaction to parity commit 5e30f7f Swiftlint commit 5e6b6c1 Big changes, the CreateAccountExample is now runnable but it throws an error commit 62a272e Make it possible to manually construct a ThresholdKey commit 6500d03 HIP-904: Allow autoMaxTokenAssociation to accept -1 & TokenReject commit 68767cd Use more idiomatic Swift styling commit 68e9073 Update README to template commit 6c57705 feat(HIP-844): add signer nonce commit 6c78eff chore(deps): bump step-security/harden-runner from 2.8.1 to 2.9.0 commit 70022f4 Remove Dockerfile; no longer needed commit 71e0246 Add various E2E tests (#100) commit 731fe4a Remove some cruft commit 7564cfa Refactor Ed25519PrivateKey to store the whole keypair instead of just the private key bytes commit 7616c19 Clean up and future-atize the execute method in QueryBuilder commit 76ae41f feat(client): various client stuff (#96) commit 78cbce4 Initialize client with Mirror Network (#411) commit 7a9c6fc WIP: CallParams part 2 commit 7cf1554 Fetch proto defintions from hedera-services commit 7e7dd3f Refactor a large pile of stuff - determining which grpc method to call is now Transaction's job - Client is now nullable in TransactionBuilder and Transaction (a couple places still need adjusting) - Add (currently failing) serialization test for AccountCreateTransaction commit 80047d5 e2e test: TokenPauseTransaction (#299) commit 8200a1b chore(deps): bump github.com/apple/swift-nio-http2 from 1.27.0 to 1.28.1 commit 85a9362 Remove FunctionResult as it was based on an old broken version of the JS SDK commit 88c1ea7 chore(deps): bump actions/checkout from 4.2.1 to 4.2.2 (#401) commit 89d96b5 Airdrop functionality commit 8b2484a Improve hexDecode to not break on non-hex characters commit 8bf7c03 Bring FileUpdate to parity commit 8cf41ad Future-atize execute on Transaction and fix minor bug in similar code for QueryBuilder commit 8e27288 Add Swift example for managing NFT allowances commit 91907c3 feat: add metadata field for tokens commit 92ee2a2 feat: Implement JSON-RPC endpoint for `AccountCreateTransaction` commit 953da17 TransactionReceiptQuery and Transaction.executeForReceipt() commit 957a7a1 Bring FileCreate to parity commit 9580a78 WIP commit 96aa5f7 Add doc comments for Client transactions/queries commit 97a4fc0 Bring QueryBuilder closer to parity commit 98a4481 Fix formatting commit 99527cf WIP commit 9968261 More parity changes commit 99fb3ea Helper Client Methods commit 9a8dc3f Move HederaError to its own file commit 9d28a42 Update x.py to allow dynamic operands commit a0b7365 Add Claim to AccountInfo & add CryptoGetClaimQuery commit a1716ca Implement ContractLogInfo commit a17d3cb chore(deps): bump step-security/harden-runner from 2.7.0 to 2.7.1 (#338) commit a2e1ca3 feat: Add DelegateContractId (#79) commit a60578d Add documentation for File*Transaction methods commit a783e31 Resolve Comments commit aa015b3 fix: Fix a couple of major bugs in execute logic (#98) commit ad64797 Bring ContractCreate to parity commit adf08f1 feat(TCK): Implement JSON-RPC endpoint for `AccountDeleteTransaction` commit b192b07 Fix account create test commit b38efae more E2E tests (#138) commit b396dfb Add more flexibility to AccountId's initializers commit b3ff7ca Add AccountId commit b4ebdc3 Pipe stderr to stdout using bash &2>1 commit b5e15aa Add CreateFileExample commit b6947a6 chore(deps): bump actions/checkout from 4.1.1 to 4.1.5 (#339) commit b74df5e Refactor AccountId/ContractId/FileId to be typealiases of EntityId commit b7b3d5a Implement TransactionRecord SDK Wrapper commit bb7a590 Add typealiases for a couple closures commit bd23087 GRPC has to be insecure to work with Hedera commit be5dd94 Add FunctionResult commit beac23d Remove Dentons proxy from Network+Config.swift (#321) commit beb008d Add grpc protos commit bf6d9f4 Bring the entity ids closer to parity commit c0c9ed1 Bump deps (protobufs are deps) (#81) commit c2f4eb0 Implement ContractCallLocalQuery commit c60a136 Use exponential backoff for Transaction#execute commit c65028c toECDSAsecp256k1PrivateKey & derive legacy ecdsa private key commit c82bc1f ci: Try enabling swift ~5.6~ and 5.8 (#84) commit c8392c3 Add TransferCrypto Example commit c882bd0 Bring FileAppend to parity commit c8d5f76 Implement Hbar type commit cc48cd5 CI commit cfb2cce feat(TCK): Implement JSON-RPC endpoint for `AccountUpdateTransaction` commit d16304f Minor tweaks to error messages commit d17d3b7 Bring this sdk closer to parity commit d6b8fb8 Update README.md commit d7a193c feat(transaction): getSignatures (#309) commit dda721d Implement PublicKey class, subclass with Ed25519PublicKey, KeyList, ThresholdKey, and ContractId Needed to refactor the entity ids to make this work in exchange for repeated code... commit e02286a Make examples take parameters from the environment commit e0d6576 docs: update usage example in README, show how to depend on dep commit e15c798 chore(deps): bump swift-actions/setup-swift from 2.0.0 to 2.1.0 commit e1d8d9d Add queryReceiptAsync, queryRecord, and queryRecordAsync to Transaction Remove executeForReceipt from Transaction and TransactionBuilder commit e259ef5 chore: document behavior of `expectedDecimals` (#141) commit e5a4845 Add setHeader to QueryBuilder commit e79038b More unit tests (#313) commit ebb7386 Add missing function for AccountAddClaimTransaction commit ec5b533 Remove Hex.swift and use Sodium's hex decoding functions instead commit ef0d3ac Remove x.py; no longer needed commit f105126 chore: run local node in e2e tests (#318) commit f198de4 fix(AccountCreateTransaction): evmAddress is actually alias (#97) commit f346164 Bring FileDelete to parity commit f438e74 Make CreateAccountTransactionTest pass, even though it's not fully identical to Java commit f77ae28 Refactor Transaction to make it have to reconstruct things less while avoiding making it store much more commit f941dd7 Get rid of most TODOs commit f9f0938 WIP commit f9fc8f2 Start filling in TransactionBuilder and Transaction functionality Signed-off-by: Roger Barker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove two Dentons proxies
Description:
Per Dentons these are seeing very little traffic and they would like to delete them to remove costs. These must be removed from docs and address books first to avoid disruption to the network.
Related issue(s):
hashgraph/hedera-docs#496
hashgraph/hedera-sdk-rust#737
Notes for reviewer:
N/A
Checklist