Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace popup feature variables in style #190

Merged
merged 14 commits into from
Dec 29, 2024
Merged

Conversation

hiddewie
Copy link
Owner

@hiddewie hiddewie commented Dec 29, 2024

Solves the problem that features with matched values (speed signals) cannot be found for display in the popup titles

@hiddewie
Copy link
Owner Author

hiddewie commented Dec 29, 2024

Line speed signals with variables

image

Two speed signal features on one node

image

@hiddewie hiddewie marked this pull request as ready for review December 29, 2024 20:56
@hiddewie hiddewie enabled auto-merge (squash) December 29, 2024 20:59
@hiddewie hiddewie merged commit 63af5e9 into master Dec 29, 2024
6 checks passed
@hiddewie hiddewie deleted the fix-feature-variable branch December 29, 2024 21:06
hiddewie added a commit that referenced this pull request Jan 6, 2025
This broke after
#190.

Too little files were renamed.

Done with
```shell
for file in (find symbols | grep -E -- '-[0-9]+.svg'); 
  mv $file (echo $file | sed -E 's/-([0-9]+)\.svg/-{\1}.svg/'); 
end
```
and manually reverting unrelated files.


Result: no more errors in the console, and working speed signals


![image](https://github.com/user-attachments/assets/b64afb6b-f4b7-44cb-8d1e-587e800c3a2e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant