Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render railway positions for low zooms without decimal #139

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

hiddewie
Copy link
Owner

@hiddewie hiddewie commented Nov 2, 2024

This solves some of the clutter on the map, now that railway positions are shown in every layer.

image

This solves some of the clutter on the map, now that railway positions are shown in every layer.
@hiddewie hiddewie marked this pull request as ready for review November 3, 2024 16:13
@hiddewie hiddewie merged commit 0875324 into master Nov 3, 2024
6 checks passed
@hiddewie hiddewie deleted the zero-positions branch November 3, 2024 16:14
@besentv
Copy link

besentv commented Nov 4, 2024

I'm honestly not the hugest fan of this change, as it makes the speed layer harder to understand. Before you could tell by the decimal point at a glance what a milestone is and what not, now you need to look how much a number is tilted to get this difference.

@hiddewie
Copy link
Owner Author

hiddewie commented Nov 6, 2024

Yes, I understand your point. I might make the the visualization between labels on rail lines different compared to the milestones. The color or the font of the milestones maybe.

@hiddewie
Copy link
Owner Author

hiddewie commented Nov 9, 2024

I made #143 to improve the differentiation between railway line labels and the milestones.

hiddewie added a commit that referenced this pull request Nov 9, 2024
Followup from #139

Changes:
- Font to a monospaced font (Fira Code)
- Color to slightly purple to differentiate from railway line labels
- Fix for railway positions without decimals cut off


![image](https://github.com/user-attachments/assets/0705f116-adcb-4d55-b100-19755cf7e38b)


![image](https://github.com/user-attachments/assets/dc8232cd-bc83-4442-9cee-adac3172edd4)


![image](https://github.com/user-attachments/assets/15f99b26-e005-4b7a-90fe-27402167fae5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants