Dark mode #135
Merged
Dark mode #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
current view
|
|
A workaround until a solution is implemented in the MapLibre style specification, is to generate two variants of each style to the JSON: one for light and one for dark mode. |
|
Infrastructure
Speed
Train protection
Electrification
Gauge
Loading gauge
Track class
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125
Add support for Dark mode.
By default the system mode is used, which auto-selects the light or dark mode based on system preferences. The user can select light or dark mode explicitly in the settings.
Uses Bootstrap's dark mode support. https://getbootstrap.com/docs/5.3/customize/color-modes/#enable-dark-mode
Requires patching some icons / colors in the MapLibre GL JS UI.
Hardcoded colors have been put into the
colorsmap and are now theme-dependenent.The style generation outputs a JSON style file per theme, and the UI selects the style based on the user's preferences.
The resulting contrast between text and the background is a bit lower than using light mode.
The colors can be tweaked more in separate PRs if needed.