Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace sinon in main package #10106

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Replace sinon in main package #10106

merged 2 commits into from
Dec 4, 2024

Conversation

Rotorsoft
Copy link
Contributor

Link to Issue

Closes: #10105

Description of Changes

  • Removes all refs to sinon in monorepo

"How We Fixed It"

Test Plan

  • Unit tested the FIXME() call.
  • CA (click around) tested on local and frack:
    • TODO page

Deployment Plan

Other Considerations

@Rotorsoft Rotorsoft merged commit df9f53a into master Dec 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbennettcw rbennettcw rbennettcw approved these changes

@kurtisassad kurtisassad kurtisassad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace sinon in commonwealth with vitest mocks
3 participants
@Rotorsoft @kurtisassad @rbennettcw