-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain erc20 vote weight + Native ETH voting #10049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Change the name of the voting strategy from "Connect ERC 20" to "Use ERC20/ETH"
This one from the ticket is not applied
- Created community on BASE and topic with native address. Vote weight is 0 for me even though I have ~0.22 base eth in my wallet.
- Cant vote on a thread in topic that uses native token.
Kapture.2024-12-02.at.16.44.57.mp4
- There are some TS error around
getTokenError
in two components
packages/commonwealth/client/scripts/views/pages/discussions/DiscussionsPage.tsx
Outdated
Show resolved
Hide resolved
packages/commonwealth/client/scripts/views/components/TokenFinder/useTokenFinder.ts
Show resolved
Hide resolved
...alth/client/scripts/views/pages/CommunityManagement/Topics/WVERC20Details/WVERC20Details.tsx
Show resolved
Hide resolved
Issue w/ native token has been fixed, UI updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be testing these changes?
Will fill a more thorough CA test plan + add lifecycle coverage |
Updated testing instructions. I tried to add a test to the lifecycle, but I was unable to figure out how to mock the TBC, likely because of the way it's exported. I attempted to update the exports to match other mocked libs, but didn't want to potentially cause a regression elsewhere. Will try again later. |
hmm, should we show fractional vote weights? so something like 0.2 votes? ideally admin sets up vote weights appropriately so that its not needed so something like 0.1 base eth = 1 vote but in cases where they dont we should have fractional vote weight |
Link to Issue
Closes: #9849
Closes: #9927
Description of Changes
Test Plan
0x429ae85883f82203D736e8fc203A455990745ca1
(CMN token) with chain set to base sepolia and vote multiplier of 1Deployment Plan
N/A
Other Considerations