Merge pull request #10119 from hicommonwealth/marcin/contest-fixes

Contest/Farcaster contest fixes
hicommonwealth · Dec 4, 2024 · 450ce85 · 450ce85
2 parents 6990943 + 93c33d7
commit 450ce85
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 89 deletions.
diff --git a/...ages/CommunityManagement/Contests/ManageContest/steps/DetailsFormStep/DetailsFormStep.tsx b/...ages/CommunityManagement/Contests/ManageContest/steps/DetailsFormStep/DetailsFormStep.tsx
@@ -244,8 +244,9 @@ const DetailsFormStep = ({
             <CWText className="contest-description">
               Launch a contest using the funds from your community wallet to
               create engagement incentives.{' '}
-              <CWText fontWeight="medium">Contests last 7 days</CWText> in
-              blockchain time.{' '}
+              <CWText fontWeight="medium">
+                Contests can be anywhere from 1 to 7 days in duration.
+              </CWText>{' '}
               <a
                 href={CONTEST_FAQ_URL}
                 rel="noopener noreferrer"
@@ -260,8 +261,7 @@ const DetailsFormStep = ({
       featureHint={{
         title: 'How do I fund my contest?',
         description:
-          'Contests are funded when community members purchase stake in the community. ' +
-          'Each transaction includes a small contribution to the community pool that can be used to fund contests.',
+          'Contests can be funded directly using any token that is on the same chain as your community.',
       }}
     >
       <div className="DetailsFormStep">

diff --git a/packages/commonwealth/client/scripts/views/pages/ContestPage/ContestPage.tsx b/packages/commonwealth/client/scripts/views/pages/ContestPage/ContestPage.tsx
@@ -88,7 +88,7 @@ const ContestPage = ({ contestAddress }: ContestPageProps) => {
               <Skeleton height={300} width="100%" />
               <Skeleton height={300} width="100%" />
             </>
-          ) : !farcasterCasts?.length ? (
+          ) : !farcasterCasts?.[0]?.replies?.length ? (
             <CWText>No entries for the contest yet</CWText>
           ) : (
             <>

diff --git a/packages/commonwealth/server/farcaster/frames/contest/checkEligibility.tsx b/packages/commonwealth/server/farcaster/frames/contest/checkEligibility.tsx
diff --git a/packages/commonwealth/server/farcaster/frames/contest/contestCard.tsx b/packages/commonwealth/server/farcaster/frames/contest/contestCard.tsx
@@ -94,15 +94,8 @@ export const contestCard = frames(async (ctx) => {
       >
         Prizes
       </Button>,
-      <Button
-        key="eligibility"
-        action="post"
-        target={`/${contest_address}/checkEligibility`}
-      >
-        Check Eligibility
-      </Button>,
       <Button key="install" action="link" target={getActionInstallUrl()}>
-        Install Upvote Action
+        Add Upvote Action
       </Button>,
     ],
   };

diff --git a/packages/commonwealth/server/farcaster/frames/contest/index.ts b/packages/commonwealth/server/farcaster/frames/contest/index.ts
@@ -1,5 +1,4 @@
-import { checkEligibility } from './checkEligibility';
 import { contestCard } from './contestCard';
 import { contestPrizes } from './contestPrizes';
 
-export { checkEligibility, contestCard, contestPrizes };
+export { contestCard, contestPrizes };
diff --git a/packages/commonwealth/server/farcaster/router.tsx b/packages/commonwealth/server/farcaster/router.tsx
@@ -1,12 +1,11 @@
 import express from 'express';
-import { checkEligibility, contestCard, contestPrizes } from './frames/contest';
+import { contestCard, contestPrizes } from './frames/contest';
 
 const farcasterRouter = express.Router();
 
 // WARNING: do not change these paths because cloudflare may route to it
 farcasterRouter.get('/:contest_address/contestCard', contestCard);
 farcasterRouter.post('/:contest_address/contestCard', contestCard);
 farcasterRouter.post('/:contest_address/contestPrizes', contestPrizes);
-farcasterRouter.post('/:contest_address/checkEligibility', checkEligibility);
 
 export default farcasterRouter;