refactor: extract hmr chunk from chunk.modules
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Nov 30, 2024
### Description Currently I'm trying a different approach from hmr-poc branch for implementing hmr. For this approach, for now I only need isolating module finalizer logic, so exposing current app format is sufficient to make prototype as in hi-ogawa/vite#6. Since this PR's change is fairly minimal, I'm hoping that we can merge this to main, so that I can experiment further on the nightly release and iterate on it. --- For the context, the idea I'm exploring is to give up `HmrModuleLoader` for now as I see some limitations (see #2866), but instead, always do a full build and extract hmr chunk by comparing `chunk.modules` between two builds, which is fortunately available for js api.
hi-ogawa
force-pushed
the
refactor-rolldown-hmr
branch
from
49ecf84 to
ea2a629
Compare
hi-ogawa
force-pushed
the
refactor-rolldown-hmr
branch
from
30ed368 to
85b3796
Compare
hi-ogawa
force-pushed
the
refactor-rolldown-hmr
branch
from
85b3796 to
8773916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-doing the same ideas from