Ssandler get ci working (#538)

* support HHVM 4.168 on ubuntu 20.04, newer versions of ubuntu don't build

* update codegen/schema

* update required hhvm version in composer.json

* remove patch version number

* fix the other job

* Revert "Update updating-schema.md (#482)"

This reverts commit 31f6773.

* remove update-schema job

.github/workflows/build-and-test.yml

@@ -6,7 +6,7 @@ on:
     - cron: "42 15 * * *"
 jobs:
   determine-latest-breaking-hhvm-version:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-20.04
     outputs:
       latest-breaking-hhvm-version: ${{steps.determine-latest-breaking-hhvm-version.outputs.latest-breaking-hhvm-version}}
     steps:
@@ -25,12 +25,10 @@ jobs:
       # Run tests on all OS's and HHVM versions, even if one fails
       fail-fast: false
       matrix:
-        os: [ubuntu]
+        os: [ubuntu-20.04]
         hhvm:
-          - ${{needs.determine-latest-breaking-hhvm-version.outputs.latest-breaking-hhvm-version}}
-          - latest
-          - nightly
-    runs-on: ${{matrix.os}}-latest
+          - 4.168
+    runs-on: ${{matrix.os}}
     steps:
       - uses: actions/checkout@v2
       - uses: hhvm/actions/hack-lint-test@master
@@ -41,70 +39,4 @@ jobs:
       - name: Lint
         run: bin/hhast-lint
       - name: Check for manually modified codegen
-        run: vendor/bin/hh-codegen-verify-signatures codegen/
-  update-schema:
-    if: github.ref_type != 'tag'
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v3
-      - uses: hhvm/actions/hack-lint-test@master
-        with:
-          hhvm: nightly
-          skip_lint: true
-          skip_tests: true
-      - if: github.event_name == 'pull_request'
-        run: bin/update-codegen
-      - if: github.event_name == 'pull_request'
-        uses: reviewdog/action-suggester@v1
-        with:
-          tool_name: Update schema
-      - if: github.event_name != 'pull_request'
-        uses: actions/checkout@v3
-        with:
-          submodules: true
-          repository: facebook/hhvm
-          path: ./.var/tmp/hhvm
-      - if: github.event_name != 'pull_request'
-        run: bin/update-schema --hhvm-path=./.var/tmp/hhvm
-      - if: github.event_name != 'pull_request'
-        id: pull-request-to-update-schema
-        uses: peter-evans/create-pull-request@v4
-        with:
-          author: HHVM/Hack Open Source <[email protected]>
-          branch: update-schema/${{github.ref_name}}
-          title: Update schema
-          commit-message: Update schema
-      - if: steps.pull-request-to-update-schema.outputs.pull-request-number
-        run: git checkout -B "${{github.ref_name}}"
-      - if: steps.pull-request-to-update-schema.outputs.pull-request-number
-        run: bin/update-codegen --dont-update-ast --update-latest-breaking-version
-      - if: steps.pull-request-to-update-schema.outputs.pull-request-number
-        id: determine-latest-breaking-hhvm-version
-        run: |
-          [[ \
-            "$(<codegen-no-rebuild/latest_breaking_version.hack)" \
-            =~ const\ string\ LATEST_BREAKING_HHVM_VERSION\ =\ \'([0-9]+\.[0-9]+)\. \
-          ]] && \
-          echo "::set-output name=latest-breaking-hhvm-version::${BASH_REMATCH[1]}"
-      - if: steps.pull-request-to-update-schema.outputs.pull-request-number
-        uses: sergeysova/jq-action@v2
-        with:
-          cmd: |
-            jq '.require.hhvm = "^${{steps.determine-latest-breaking-hhvm-version.outputs.latest-breaking-hhvm-version}}"' composer.json > composer.json.tmp && mv composer.json.tmp composer.json
-      - if: steps.pull-request-to-update-schema.outputs.pull-request-number
-        uses: dorny/paths-filter@v2
-        id: filter
-        with:
-          base: HEAD
-          filters: |
-            any-changes: '**'
-      - if: steps.pull-request-to-update-schema.outputs.pull-request-number && steps.filter.outputs.any-changes == 'true'
-        uses: peter-evans/create-pull-request@v4
-        with:
-          author: HHVM/Hack Open Source <[email protected]>
-          branch: update-latest-breaking-version/${{github.ref_name}}
-          title: Update schema to a backward incompatible version
-          commit-message: Update the latest breaking version
-          body: |
-            This PR assumes the latest schema is a breaking change.
-            Feel free to close this PR and instead merge #${{steps.pull-request-to-update-schema.outputs.pull-request-number}}, if the schema is actually backward compatible with previous schema versions.
+        run: vendor/bin/hh-codegen-verify-signatures codegen/