CODATA 2022 update #2049
CODATA 2022 update #2049
Conversation
CodSpeed Performance ReportMerging #2049 will not alter performanceComparing Summary
|
Like most "measured constants", they're not measured directly, but derived from other measures. However, the list of CODATA values includes these (and their uncertainties and correlations), so it's better to treat them as other constants.
|
Is there anything I should fix? I don't think any documentation (beyond the changelog) or any new test is needed. And surely the PR is not going to be rejected for those µs in the benchmark? |
|
No, nothing to fix. It needs a maintainer to take the time to confirm the
numbers are all correct.
…On Mon, 23 Sept 2024, 13:55 Jellby, ***@***.***> wrote:
Is there anything I should fix? I don't think any documentation (beyond
the changelog) or any new test is needed. And surely the PR is not going to
be rejected for those µs in the benchmark?
—
Reply to this email directly, view it on GitHub
<#2049 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADEMLEDVP7M5E3F5MZUXC3TZYAFSTAVCNFSM6AAAAABM4CR6Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRYGE2DCNZQGI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
| electron_mass = 9.1093837015e-31 kg = m_e = atomic_unit_of_mass = a_u_mass # (28) | ||
| proton_mass = 1.67262192369e-27 kg = m_p # (51) | ||
| neutron_mass = 1.67492749804e-27 kg = m_n # (95) | ||
| lattice_spacing_of_Si = 1.920155716e-10 m = d_220 # (32) |
There was a problem hiding this comment.
you've removed this and the following K_ constants from the default units (but they're available in pint-convert). Is there a reason why?
There was a problem hiding this comment.
I've removed them from pint-convert too, haven't I?
Those constants, as far as I can see, are only relevant to define the "X units" and the Å*, but the NIST website does not give values or correlations for them. So I decided it's better to define the units as constants directly.
There was a problem hiding this comment.
thanks that makes senes
Update physical constant values to the latest CODATA 2022 recommended values (from https://pml.nist.gov/cuu/Constants/). Small change, but there's no reason to stay outdated 😁
pre-commit run --all-fileswith no errors