feat(breadcrumbs): add seo breadcrumbList schema #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add seo breadcrumbList schema
|
Compiled a new version demo. |
ayhansipahi
reviewed
May 26, 2023
| @@ -83,22 +97,33 @@ const Breadcrumbs: FC<BreadcrumbsProps> = ({ | |||
| hiddenBreadcrumbs.map((breadcrumb, i) => { | |||
There was a problem hiding this comment.
Is it possible to keep breadcrumbs in the DOM and hide it with css? If dom is not available in server side rendered html, it might cause crawling issues.
cc @Nazzanuk
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 5256111206
💛 - Coveralls |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success402 tests passing in 57 suites. Report generated by 🧪jest coverage report action from 67bce36 |
nathanjamal
approved these changes
Jun 13, 2023
esraltintas
force-pushed
the
feat/HEYUI-349
branch
from
67bce36 to
d22827b
Compare
|
Compiled a new version demo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add seo breadcrumbList schema
Pull Request
Description
Describe your changes (or add ticket description) and add relevant screenshots
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!