Shared type PropsBasedOnComponent #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compiled a new version demo. |
|
Compiled a new version demo. |
|
Compiled a new version demo. |
Pull Request Test Coverage Report for Build 4355349209
💛 - Coveralls |
|
Compiled a new version demo. |
Coverage report
Test suite run success273 tests passing in 41 suites. Report generated by 🧪jest coverage report action from 4654fa5 |
lucasmaffazioli
requested review from
frankie303
and removed request for
nathanjamal and
esraltintas
frankie303
reviewed
Mar 8, 2023
Comment on lines
+12
to
+13
| // export Col is necessary with PropsBasedOnComponent due to a Storybook bug | ||
| export const Col: PropsBasedOnComponent<ColProps, 'div'> = ({ |
There was a problem hiding this comment.
should we keep the default export in this case (IMO we shouldn't) and what is the Storybook bug?
| type ColBaseProps<E extends React.ElementType> = { | ||
| export interface ColProps { |
There was a problem hiding this comment.
can you also update Row and Container as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
While developing
Pagination, it was created a type for getting props based on a passed component props.In the below example,
componentreceivesLink, which has thelinkprop, which then is available on PaginationItem, with this, we have PropsBasedOnComponent.This is also called Polymorphic component.
This change is only to include this generic type for Grid.Col as well.
Type of change
How do I test this
Checklist
Did you remember to take care of the following?
npm i– for new NPM dependencies.npm run lint- to check for linting issuesnpm run test- to run unit testsnpm run test:sh:docker- to run screenshot tests, detail instructionNew Feature / Bug Fix
Thanks for contributing!