added useLegacyEnums option #144
Conversation
|
Yes, trying to figure out why the test fail |
Probably the snapshots for test need to be updated with npm run test:update. I am ok adding this in, but is there a reason you can't use --enums and update your uses to use those. They work pretty much the same |
|
They almost work the same, except the new enum name has Enum as a postfix, this would mean that we have to update our 100+ enums in over 2000 vue-files. This option would allow us to upgrade to this package first, and the do the useOptions / Enums upgrade later |
Ok, I am ok with adding this back (after comments are fixed and tests updated/minor changeset added). But it would be under the assumption that it would be removed again at some point (likely when we start migrating away from handlebars) |
What do you want to start using? |
Maybe the typescript compiler api to generate the files. Also the snapshots should not differ with this change (the reason they do is the whitespace added to the templates) |
|
@mlankamp Once you have fixed the changes and added a changeset, I will merge this and create a release for you to use. Thanks for the contribution |
|
What do you mean with changeset? |
Run |
| export type {{{name}}} = {{{enumUnionType enum}}}; | ||
| {{/if}} | ||
|
|
||
| {{/if}} | ||
| {{#if @root.$config.enums}} |
There was a problem hiding this comment.
Add back one newline above this (below {{/if}}
There was a problem hiding this comment.
@mlankamp Please add back one newline, run npm run test:update and then add the changeset as mentioned above, I cannot modify this PR. Then I will merge and release
|
Completed in #147 |
Enables an --useLegacyEnums options as requested in #143