Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add buildUrl and querySerializer to Axios client #1420

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 12, 2024

No description provided.

Copy link

stackblitz bot commented Dec 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review December 12, 2024 14:15
Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 2:15pm

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 8010dbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@hey-api/openapi-ts Patch
@hey-api/client-axios Minor
@hey-api/docs Patch
@example/openapi-ts-axios Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 63.76%. Comparing base (9ad666d) to head (8010dbb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 33.33% 22 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1420   +/-   ##
=======================================
  Coverage   63.75%   63.76%           
=======================================
  Files         141      141           
  Lines       22106    22104    -2     
  Branches     1844     1844           
=======================================
  Hits        14094    14094           
+ Misses       8006     8004    -2     
  Partials        6        6           
Flag Coverage Δ
unittests 63.76% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit f8274b4 into main Dec 12, 2024
15 of 16 checks passed
@mrlubos mrlubos deleted the fix/client-axios-query-styles branch December 12, 2024 14:24
@github-actions github-actions bot mentioned this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant