Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infer responseType in SDKs for axios client #1419

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Dec 12, 2024

No description provided.

Copy link

stackblitz bot commented Dec 12, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@mrlubos mrlubos marked this pull request as ready for review December 12, 2024 13:00
Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 4555796

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hey-api/openapi-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 1:00pm

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 24.00000% with 57 lines in your changes missing coverage. Please review.

Project coverage is 63.75%. Comparing base (322eccb) to head (4555796).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 22.97% 57 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1419      +/-   ##
==========================================
- Coverage   63.89%   63.75%   -0.14%     
==========================================
  Files         141      141              
  Lines       22033    22106      +73     
  Branches     1843     1844       +1     
==========================================
+ Hits        14078    14094      +16     
- Misses       7949     8006      +57     
  Partials        6        6              
Flag Coverage Δ
unittests 63.75% <24.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mrlubos mrlubos merged commit 9ad666d into main Dec 12, 2024
14 of 16 checks passed
@mrlubos mrlubos deleted the fix/axios-response-type branch December 12, 2024 13:10
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant