fix(parser): parse array items only if parent has no other item type #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrlubos
force-pushed
the
fix/any-of-arrays
branch
3 times, most recently
from
51b1091 to
5956562
Compare
mrlubos
commented
Feb 4, 2024
| @@ -26,7 +26,7 @@ export interface OpenApiSchema extends OpenApiReference, WithEnumExtension { | |||
| required?: string[]; | |||
| enum?: (string | number)[]; | |||
| type?: string | string[]; | |||
| const?: string | number | null; | |||
| const?: string | number | boolean | null; | |||
There was a problem hiding this comment.
@nicolas-chaulet reverting your earlier change 4a01f7d#diff-f63840bc9f1fce487110ca8c6f00e21f4039ecbe9f036ec355dfa731132cc93eR29
| @@ -4218,7 +4220,7 @@ import type { Enum1 } from './Enum1'; | |||
| * This is a model with one property with a 'any of' relationship where the options are not $ref | |||
| */ | |||
| export type CompositionWithNestedAnyOfAndNull = { | |||
| propA?: ((Enum1 | ConstValue) | null); | |||
| propA?: (Array<(Enum1 | ConstValue)> | null); | |||
There was a problem hiding this comment.
@nicolas-chaulet reverting your earlier change 4a01f7d#diff-f96c002010932e16fe6778d2c9ff94a719d2b7ddc38076eabc474b618b9be108R4127
| @@ -4201,7 +4203,7 @@ import type { ModelWithDictionary } from './ModelWithDictionary'; | |||
| * This is a model with nested 'any of' property with a type null | |||
| */ | |||
| export type CompositionWithNestedAnyAndTypeNull = { | |||
| propA?: ((ModelWithDictionary | null) | (ModelWithArray | null)); | |||
| propA?: (Array<(ModelWithDictionary | null)> | Array<(ModelWithArray | null)>); | |||
There was a problem hiding this comment.
mrlubos
changed the title
mrlubos
force-pushed
the
fix/any-of-arrays
branch
from
5956562 to
c1d8979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.