Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get skyrim working again #71

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

W-Drew
Copy link

@W-Drew W-Drew commented Dec 28, 2023

The current release of NifSkop cannot save bhkCompressedMeshShapeData in Skyrim meshes as reported by #67. The current develop branch has also drifted from the nif.xml the latest release is using and spews various warnings when a binary built from develop is used without first updating the nif.xml. This PR makes the following changes:

  1. Bug with bhkCompressedMeshShapeData is fixed as described by @Candoran2 in [Dev 9] Error saving some files with CMS collision #67. It was a small issue introduced in 1365ca1d6d68a6b3d18efe1c5c43a7c605313939 where we told Qt to write 6 bytes but that we wanted 3 bytes in return. Updated to expect 6 bytes in return

  2. Checked in the nif.xml from the current release to source control as-is with no edits

  3. Upstream @Candoran2's build file. Getting Nifskope to build took a lot of troubleshooting since it was unclear which versions of Qt & VS toolchain were being used to build the latest releases and older versions of Qt/VS toolchain would fail to build. With this, there is no longer ambiguity.

  4. Add vscode's local files to gitignore

W-Drew added a commit to W-Drew/nifskope that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant