Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed to load plugin schemas #764

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Conversation

apricote
Copy link
Member

@apricote apricote commented Oct 5, 2023

The schemas between the Plugin SDK Provider and the Plugin Framework Provider have different values. This is not allowed, as it causes inconstency, and the terraform-provider stops on startup with an error if this is detected.

The "token" is not truly required in the old provider (or the new), because we fallback to the HCLOUD_TOKEN environment variable and have additional validation that verifies it is set.

Closes #763

Related to #752

The schemas between the Plugin SDK Provider and the Plugin Framework
Provider have different values. This is not allowed, as it causes
inconstency, and the terraform-provider stops on startup with an error
if this is detected.

The "token" is not truly required in the old provider (or the new),
because we fallback to the HCLOUD_TOKEN environment variable and have
additional validation that verifies it is set.
@apricote apricote requested a review from jooola October 5, 2023 05:42
@apricote apricote self-assigned this Oct 5, 2023
@apricote apricote merged commit b68a97c into main Oct 5, 2023
4 checks passed
@apricote apricote deleted the provider-different-schema branch October 5, 2023 07:53
apricote pushed a commit that referenced this pull request Oct 5, 2023
🤖 I have created a release *beep* *boop*
---


##
[1.44.1](v1.44.0...v1.44.1)
(2023-10-05)


### Bug Fixes

* failed to load plugin schemas
([#764](#764))
([b68a97c](b68a97c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Invalid Provider Server Combination
2 participants