test: make sure that old and new implementation is the same

hetznercloud · Nov 14, 2023 · e42f420 · e42f420
1 parent 81d4d25
commit e42f420
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 7 deletions.
diff --git a/internal/datacenter/data_source.go b/internal/datacenter/data_source.go
@@ -15,6 +15,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+
 	"github.com/hetznercloud/hcloud-go/hcloud"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/hcclient"
 )
@@ -155,7 +156,7 @@ Use this resource to get detailed information about specific datacenter.
 ## Example Usage
 ` + "```" + `hcl
 data "hcloud_datacenter" "ds_1" {
-  name = "fsn1-dc8"
+  name = "fsn1-dc14"
 }
 data "hcloud_datacenter" "ds_2" {
   id = 4

diff --git a/internal/e2etests/datacenter/data_source_test.go b/internal/e2etests/datacenter/data_source_test.go
@@ -3,10 +3,10 @@ package datacenter_test
 import (
 	"testing"
 
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
+
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/datacenter"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/e2etests"
-
-	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/testtemplate"
 )
 
@@ -63,19 +63,33 @@ func TestAccHcloudDataSourceDatacenter_UpgradePluginFramework(t *testing.T) {
 						VersionConstraint: "1.42.1",
 						Source:            "hetznercloud/hcloud",
 					},
+					"null": {
+						VersionConstraint: "3.2.1",
+						Source:            "hashicorp/null",
+					},
 				},
 
 				Config: tmplMan.Render(t,
 					"testdata/d/hcloud_datacenter", dcByName,
 					"testdata/d/hcloud_datacenter", dcByID,
+					"testdata/r/null_resource", dcByName,
+					"testdata/r/null_resource", dcByID,
 				),
 			},
 			{
+				ExternalProviders: map[string]resource.ExternalProvider{
+					"null": {
+						VersionConstraint: "3.2.1",
+						Source:            "hashicorp/null",
+					},
+				},
 				ProtoV6ProviderFactories: e2etests.ProtoV6ProviderFactories(),
 
 				Config: tmplMan.Render(t,
 					"testdata/d/hcloud_datacenter", dcByName,
 					"testdata/d/hcloud_datacenter", dcByID,
+					"testdata/r/null_resource", dcByName,
+					"testdata/r/null_resource", dcByID,
 				),
 
 				PlanOnly: true,

diff --git a/internal/e2etests/firewall/resource_test.go b/internal/e2etests/firewall/resource_test.go
@@ -4,13 +4,12 @@ import (
 	"fmt"
 	"testing"
 
-	"github.com/hetznercloud/terraform-provider-hcloud/internal/e2etests"
+	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/stretchr/testify/assert"
 
-	"github.com/hetznercloud/terraform-provider-hcloud/internal/firewall"
-
-	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
 	"github.com/hetznercloud/hcloud-go/hcloud"
+	"github.com/hetznercloud/terraform-provider-hcloud/internal/e2etests"
+	"github.com/hetznercloud/terraform-provider-hcloud/internal/firewall"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/testsupport"
 	"github.com/hetznercloud/terraform-provider-hcloud/internal/testtemplate"
 )

diff --git a/internal/e2etests/testing.go b/internal/e2etests/testing.go
@@ -6,6 +6,7 @@ import (
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-go/tfprotov6"
+
 	"github.com/hetznercloud/hcloud-go/hcloud"
 	tfhcloud "github.com/hetznercloud/terraform-provider-hcloud/hcloud"
 )

diff --git a/internal/testdata/r/null_resource.tf.tmpl b/internal/testdata/r/null_resource.tf.tmpl
@@ -0,0 +1,9 @@
+// This template can be used to work around a bug/limitation in terraform-test-framework, which only checks for plan
+// changes in resources, not in datasources or outputs.
+// You can pass any [testtemplate.DataCommon] to it.
+
+resource "null_resource" "{{ .RName }}" {
+  triggers = {
+    resource = jsonencode({{ .TFID }})
+  }
+}