-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move tools in a module to reduce root module bloat #559
base: main
Are you sure you want to change the base?
Conversation
2f25a28
to
f2d15d8
Compare
While I personally like the division in "prod" and "dev" dependencies, I also appreciate the simplicity of using In addition, while these dependencies are in our |
Yes, I agree that the simplicity of Part of the reason why I did this is that we have those jobs failing, a bit too often, for me to tidy the files manually every time: https://github.com/hetznercloud/hcloud-go/actions/runs/11889479028/job/33126124091?pr=550#step:4:28 We could simplify this by using a makefile, and skipping go generate all together, would that work for you? |
At that point we could just let renovate run
That would also work, personally not that much of a fan of Makefiles if it can also be done in a language-native way, but I would not block it. |
Why do we need a Makefile instead of doing it like in hetznercloud/cli#901 with |
I am stepping back from this PR, @phm07 will take a look at this to see if its worth it. |
Go 1.24 will add a |
Wouldn't we need to update the module to 1.24 then as well? Since the new directive goes into the go.mod |
This moves the tools dependencies in a dedicated module to reduce the bloat of the root module.
This should also reduce the amount of failed check generated CI jobs in renovate PRs, by not sharing the deps between our library and the tools that we are using.
The mix of make files and go generate seems unnecessarily complex, we might want to move everything to make files if this turns out to be painful.