ci: added pre-commit

[lukasmetzner]

This PR introduces a pre-commit config which is used in our ci pipeline. Furthermore, an additional formatting of all affected resources was done.

The following config was used as a baseline: https://github.com/hetznercloud/.github/blob/main/.pre-commit-config.yaml

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.34%. Comparing base (9e9d983) to head (4f003f2).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #811   +/-   ##
=======================================
  Coverage   35.34%   35.34%           
=======================================
  Files          20       20           
  Lines        1901     1901           
=======================================
  Hits          672      672           
  Misses       1195     1195           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jooola]

I'd rather keep the snapshots in there, if pre-commit fails on the snapshots, the templates might need a fix.

[lukasmetzner]

Running prettier and helm template causes some conflicts. pre-commit (prettier) wants to format the yaml. In the CI we check for a diff after running helm template, which always fails as the formatting is different.

Should we write a custom pre-commit hook to address this?

[jooola]

Yes, this what I had in mind with #811 (comment)

[jooola]

There are a bunch of script in https://github.com/hetznercloud/csi-driver/tree/main/hack that could be run as part of pre-commit :)

This could also remove a few CI jobs running those scripts.

[jooola]

The snapshots are ignored by prettier because it is a pain to fix the helm templates, this task can be picked up by anyone having the energy to do it.

🧹