-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(nomad): improved nomad support #798
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #798 +/- ##
==========================================
- Coverage 35.34% 32.38% -2.97%
==========================================
Files 20 21 +1
Lines 1901 2075 +174
==========================================
Hits 672 672
- Misses 1195 1369 +174
Partials 34 34 ☔ View full report in Codecov by Sentry. |
With respect to version testing: Enterprise users will have access to more support for the current major version and the two previous major versions. In addition, there are LTS versions available. Further information can be found here. Running enterprise products requires the license to be present on startup. |
447c284
to
63b87ba
Compare
Regarding the tested versions: I think we should start with the latest version only. If there are many Nomad enterprise users who would like to see the |
One more thing: There are a lot of files with missing newline at eof. Could you add it to all the files? |
d01edf6
to
db2f3f6
Compare
8d65b94
to
acc0b71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just a nit :)
13f92f4
to
c501c5e
Compare
Added volume resize request and validation. Added plugin information request and validation.
In this test a job is created which writes a test file of 1M to a Hetzner Cloud volume. Afterwards, this job is deleted and another job on another node is started, that verifies that the file is present and has a size greater than zero.
Co-authored-by: Julian Tölle <[email protected]>
Co-authored-by: Julian Tölle <[email protected]>
Accidentally removed the wrong commit from the history. This reintroduces the changes and adds a controller count of 2 back to the official guide.
Co-authored-by: Jonas L. <[email protected]>
Co-authored-by: Jonas L. <[email protected]>
7b970e4
to
2e2220a
Compare
This PR adds better support for our integration with Nomad. Although not officially supported, we would like to improve the developer experience and integrate automated e2e tests to avoid breaking Nomad integrations with future csi-driver releases.
The Terraform module for creating a Nomad (+Consul) cluster on Hetzner Cloud can be found here.
Steps, that still need to be done: