ci: run tests on main to get coverage comparison #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests are currently only executed for PRs. This has two downsides: - Coverage comparison in PRs is not available - If two PRs modify similar code, they have the potential to break tests, this would only be discovered once a new PR is opened.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
=======================================
Coverage ? 43.26%
=======================================
Files ? 12
Lines ? 1389
Branches ? 0
=======================================
Hits ? 601
Misses ? 769
Partials ? 19 ☔ View full report in Codecov by Sentry. |
|
Haha, this was on my radar, thanks for fixing this. |
jooola
approved these changes
Jan 13, 2024
|
Hehe, stumbled upon this while checking out the Codecov dashboard. |
lukasmetzner
pushed a commit
that referenced
this pull request
Oct 10, 2024
Tests are currently only executed for PRs. This has two downsides: - Coverage comparison in PRs is not available - If two PRs modify similar code, they have the potential to break tests, this would only be discovered once a new PR is opened.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests are currently only executed for PRs. This has two downsides: