Replace commons logger with bullet_stream
#993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the buildpacks here were early adopters of the output module originally developed [in the Ruby buildpack](https://github.com/heroku/buildpacks-ruby/blob/221fe5bd5bfc5e2715e3810ce353a1252564f012/commons/src/output/mod.rs). This output module has been replaced by [bullet_stream](https://github.com/heroku-buildpacks/bullet_stream). Eventually, all the buildpacks here will use [bullet_stream](https://github.com/heroku-buildpacks/bullet_stream). For now, I'm just migrating over the existing usage so that I no longer have to deal with errors like this: https://github.com/heroku/heroku-buildpack-nodejs/actions/runs/12626267505/job/35179157027#step:4:24
edmorley
approved these changes
Jan 7, 2025
heroku-linguist bot
added a commit
that referenced
this pull request
Jan 7, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.1`. - Updated `heroku/nodejs-engine` to `3.4.1`. - Updated `heroku/nodejs-npm-engine` to `3.4.1`. - Updated `heroku/nodejs-npm-install` to `3.4.1`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.1`. - Updated `heroku/nodejs-pnpm-install` to `3.4.1`. - Updated `heroku/nodejs-yarn` to `3.4.1`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine ### Added - 23.5.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.1`. - Updated `heroku/nodejs-function-invoker` to `3.4.1`. - Updated `heroku/nodejs-npm` to `3.4.1`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine ### Changed - Added npm version 11.0.0. - Replaced `commons` output module with `bullet_stream`. ([#993](#993)) ## heroku/nodejs-npm-install ### Changed - Replaced `commons` output module with `bullet_stream` ([#993](#993)) ## heroku/nodejs-pnpm-engine ### Changed - Replaced `commons` output module with `bullet_stream` ([#993](#993)) ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - Added Yarn version 4.6.0.
Merged
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Jan 7, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.1`. - Updated `heroku/nodejs-engine` to `3.4.1`. - Updated `heroku/nodejs-npm-engine` to `3.4.1`. - Updated `heroku/nodejs-npm-install` to `3.4.1`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.1`. - Updated `heroku/nodejs-pnpm-install` to `3.4.1`. - Updated `heroku/nodejs-yarn` to `3.4.1`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine ### Added - 23.5.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.1`. - Updated `heroku/nodejs-function-invoker` to `3.4.1`. - Updated `heroku/nodejs-npm` to `3.4.1`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine ### Changed - Added npm version 11.0.0. - Replaced `commons` output module with `bullet_stream`. ([#993](heroku/buildpacks-nodejs#993)) ## heroku/nodejs-npm-install ### Changed - Replaced `commons` output module with `bullet_stream` ([#993](heroku/buildpacks-nodejs#993)) ## heroku/nodejs-pnpm-engine ### Changed - Replaced `commons` output module with `bullet_stream` ([#993](heroku/buildpacks-nodejs#993)) ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - Added Yarn version 4.6.0.
heroku-linguist bot
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Jan 7, 2025
## heroku/nodejs ### Changed - Updated `heroku/nodejs-corepack` to `3.4.1`. - Updated `heroku/nodejs-engine` to `3.4.1`. - Updated `heroku/nodejs-npm-engine` to `3.4.1`. - Updated `heroku/nodejs-npm-install` to `3.4.1`. - Updated `heroku/nodejs-pnpm-engine` to `3.4.1`. - Updated `heroku/nodejs-pnpm-install` to `3.4.1`. - Updated `heroku/nodejs-yarn` to `3.4.1`. ## heroku/nodejs-corepack - No changes. ## heroku/nodejs-engine ### Added - 23.5.0 (linux-amd64, linux-arm64) ## heroku/nodejs-function ### Changed - Updated `heroku/nodejs-engine` to `3.4.1`. - Updated `heroku/nodejs-function-invoker` to `3.4.1`. - Updated `heroku/nodejs-npm` to `3.4.1`. ## heroku/nodejs-function-invoker - No changes. ## heroku/nodejs-npm - No changes. ## heroku/nodejs-npm-engine ### Changed - Added npm version 11.0.0. - Replaced `commons` output module with `bullet_stream`. ([#993](heroku/buildpacks-nodejs#993)) ## heroku/nodejs-npm-install ### Changed - Replaced `commons` output module with `bullet_stream` ([#993](heroku/buildpacks-nodejs#993)) ## heroku/nodejs-pnpm-engine ### Changed - Replaced `commons` output module with `bullet_stream` ([#993](heroku/buildpacks-nodejs#993)) ## heroku/nodejs-pnpm-install - No changes. ## heroku/nodejs-yarn - Added Yarn version 4.6.0. Co-authored-by: heroku-linguist[bot] <136119646+heroku-linguist[bot]@users.noreply.github.com>
colincasey
added a commit
that referenced
this pull request
Jan 9, 2025
One of the features of the `commons` logger that was removed in #993 was the ability to collect log messages that would be emitted at a later point. This feature is not available in `bullet_stream` so when I moved the logging message that notifies the user they've checked in their `node_modules` directory to the end of the build phase, I mistakenly moved the timing of that check to run at the end of the build phase as well. This check needs to run at the beginning of the build phase and the warning needs to be emitted at the end. This PR contains changes to do this + adds an integration test to verify this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the buildpacks here were early adopters of the output module originally developed in the Ruby buildpack. This output module has been replaced by bullet_stream.
Eventually, all the buildpacks here will use bullet_stream. For now, I'm just migrating over the existing usage so that I no longer have to deal with errors like this:
https://github.com/heroku/heroku-buildpack-nodejs/actions/runs/12626267505/job/35179157027#step:4:24