Merge pull request magento#7403 from magento-lynx/AC-2080_release-mag…

…ento-coding-standard

AC-2080: Release magento-coding-standard

app/code/Magento/Backend/view/adminhtml/web/js/dashboard/chart.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/*global define*/
 /*global FORM_KEY*/
 define([
     'jquery',

app/code/Magento/Backend/view/adminhtml/web/js/dashboard/totals.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/*global define*/
 /*global FORM_KEY*/
 define([
     'jquery',

app/code/Magento/Bundle/view/adminhtml/web/js/bundle-product.js

@@ -5,7 +5,6 @@
 
 /*global FORM_KEY*/
 /*global bSelection*/
-/*global $H*/
 /**
  * @api
  */
@@ -186,7 +185,9 @@ define([
                                 });
                                 bSelection.gridRemoval.each(function (pair) {
                                     $optionBox.find('.col-sku').filter(function () {
-                                        return $(this).text().trim() === pair.key; // find row by SKU
+                                        let text = $(this).text();
+
+                                        return text.trim() === pair.key; // find row by SKU
                                     }).closest('tr').find('button.delete').trigger('click');
                                 });
                                 widget.refreshSortableElements();

app/code/Magento/Captcha/view/frontend/web/js/model/captcha.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/*global alert*/
 define([
     'jquery',
     'ko',

app/code/Magento/Catalog/view/adminhtml/web/catalog/base-image-uploader.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/*global alert:true*/
 define([
     'jquery',
     'mage/template',

app/code/Magento/Catalog/view/adminhtml/web/catalog/category/assign-products.js

@@ -3,8 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/* global $, $H */
-
 define([
     'mage/adminhtml/grid'
 ], function () {

app/code/Magento/Catalog/view/base/web/js/price-utils.js

@@ -27,7 +27,7 @@ define([
      * @return {String}
      */
     function stringPad(string, times) {
-        return (new Array(times + 1)).join(string);
+        return new Array(times + 1).join(string);
     }
 
     /**

app/code/Magento/CheckoutAgreements/view/frontend/web/js/model/agreements-assigner.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/*global alert*/
 define([
     'jquery'
 ], function ($) {

app/code/Magento/CheckoutAgreements/view/frontend/web/js/model/set-payment-information-mixin.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/*global alert*/
+
 define([
     'jquery',
     'mage/utils/wrapper',

app/code/Magento/GroupedProduct/view/adminhtml/web/js/grouped-product.js

@@ -159,7 +159,9 @@ define([
                         product.id = element.val();
                         product.qty = 0;
                         element.closest('[data-role=row]').find('[data-column]').each(function (index, el) {
-                            product[$(el).data('column')] = $(el).text().trim();
+                            let text = $(el).text();
+
+                            product[$(el).data('column')] = text.trim();
                         });
                         selectedProductList[product.id] = product;
                     } else {

app/code/Magento/Integration/view/adminhtml/web/js/integration.js

@@ -365,7 +365,7 @@ define([
                     try {
                         // Get integration name either from current element or from neighbor column
                         integrationName = $(ctx).attr('data-row-name') ||
-                            $(ctx).parents('tr').find('.col-name').html().trim();
+                            $(ctx).parents('tr').find('.col-name').html().trim(); // eslint-disable-line jquery-no-trim
 
                         if (integrationName.indexOf('<span') > -1) {
                             // Remove unsecure URL warning from popup window title if it is present

app/code/Magento/MediaGalleryUi/view/adminhtml/web/js/grid/messages.js

@@ -70,6 +70,7 @@ define([
 
             delay = delay || this.messageDelay;
 
+            // eslint-disable-next-line no-unused-vars
             timerId = setTimeout(function () {
                 clearTimeout(timerId);
                 this.clear();

app/code/Magento/Paypal/view/adminhtml/web/js/payflowpro/vault.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 /*browser:true*/
-/*global define*/
+
 define([
     'jquery',
     'uiComponent'

app/code/Magento/Paypal/view/frontend/web/js/order-review.js

@@ -285,7 +285,9 @@ define([
             isChecked = $(this.options.billingAsShippingSelector).is(':checked');
             formData = null;
             callBackResponseHandler = null;
-            shippingMethod = $(this.options.shippingSelector).val().trim();
+            let val = $(this.options.shippingSelector).val();
+
+            shippingMethod = val.trim();
             this._shippingTobilling();
 
             if (url && resultId && shippingMethod) {
@@ -358,7 +360,9 @@ define([
          * Actions on change Shipping Address data
          */
         _onShippingChange: function () {
-            if (this.triggerPropertyChange && $(this.options.shippingSelector).val().trim()) {
+            let val = $(this.options.shippingSelector).val();
+
+            if (this.triggerPropertyChange && val.trim()) {
                 this.element.find(this.options.shippingSelector).hide().end()
                     .find(this.options.shippingSelector + '_update').show();
             }

app/code/Magento/ProductVideo/view/adminhtml/web/js/get-video-information.js

@@ -606,7 +606,7 @@ define([
              * @private
              */
             _formatVimeoDuration: function (seconds) {
-                return (new Date(seconds * 1000)).toUTCString().match(/(\d\d:\d\d:\d\d)/)[0];
+                return new Date(seconds * 1000).toUTCString().match(/(\d\d:\d\d:\d\d)/)[0];
             },
 
             /**

app/code/Magento/Security/view/adminhtml/web/js/system/config/session-size.js

@@ -17,7 +17,7 @@ define([
         $inputEl.on('blur', function () {
             var inputVal = parseInt($inputEl.val(), 10);
 
-            if (256000 > inputVal) {
+            if (inputVal < 256000) {
                 confirm({
                     title: $t(config.modalTitleText),
                     content: $t(config.modalContentBody),

app/code/Magento/Swatches/view/adminhtml/web/js/form/element/swatch-visual.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 
-/* global $break $ FORM_KEY */
+/* global FORM_KEY */
 
 /**
  * @api

app/code/Magento/Swatches/view/adminhtml/web/js/text.js

@@ -3,8 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/* global $break $ $$ */
-
 /**
  *  @api
  */

app/code/Magento/Swatches/view/adminhtml/web/js/visual.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 
-/* global $break $ $$ FORM_KEY */
+/* global FORM_KEY */
 
 /**
  * @api

app/code/Magento/Ui/view/base/web/js/lib/core/events.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/* global WeakMap, Map*/
 define([
     'ko',
     'underscore'

app/code/Magento/Ui/view/base/web/js/lib/knockout/bindings/optgroup.js

@@ -265,7 +265,7 @@ define([
              * @returns {Array}
              */
             function strPad(string, times) {
-                return (new Array(times + 1)).join(string);
+                return new Array(times + 1).join(string);
             }
 
             /**

app/code/Magento/Ui/view/base/web/js/lib/knockout/extender/bound-nodes.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/* global WeakMap */
 define([
     'ko',
     'underscore',

app/code/Magento/Ui/view/base/web/js/lib/registry/registry.js

@@ -6,7 +6,6 @@
 /**
  * @api
  */
-/* global WeakMap */
 define([
     'jquery',
     'underscore'

app/code/Magento/Ui/view/base/web/js/lib/view/utils/raf.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 
-/* global WeakMap */
 define([], function () {
     'use strict';
 

app/code/Magento/Ui/view/base/web/js/modal/modal-component.js

@@ -234,7 +234,7 @@ define([
             }
 
             if (typeof elem.validate === 'function') {
-                this.valid = this.valid & elem.validate().valid;
+                this.valid &= elem.validate().valid;
             } else if (elem.elems) {
                 elem.elems().forEach(this.validate, this);
             }

app/code/Magento/Vault/view/adminhtml/web/js/vault.js

@@ -3,7 +3,6 @@
  * See COPYING.txt for license details.
  */
 /*browser:true*/
-/*global define*/
 /* @api */
 define([
     'jquery',

app/code/Magento/Vault/view/frontend/web/js/view/payment/method-renderer/vault.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 /*browser:true*/
-/*global define*/
+
 define(
     [
         'Magento_Checkout/js/view/payment/default',

app/code/Magento/Vault/view/frontend/web/js/view/payment/vault-enabler.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 /*browser:true*/
-/*global define*/
+
 /* @api */
 define(
     [

app/code/Magento/Vault/view/frontend/web/js/view/payment/vault.js

@@ -3,7 +3,7 @@
  * See COPYING.txt for license details.
  */
 /*browser:true*/
-/*global define*/
+
 /* @api */
 define([
     'underscore',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/base/js/product/list/columns/final-price.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/base/js/product/list/columns/image.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/storage/data-storage.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/storage/ids-storage-compare.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/storage/ids-storage.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/product/storage/storage-service.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',

dev/tests/js/jasmine/tests/app/code/Magento/Catalog/frontend/js/storage-manager.test.js

@@ -2,7 +2,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
-/* global jQuery */
+
 /* eslint-disable max-nested-callbacks */
 define([
     'jquery',