Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address SHA1 case issue #27

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

tomekit
Copy link
Contributor

@tomekit tomekit commented May 5, 2024

Address SHA1 case issue.

Related #21 and rclone/rclone#7345 (comment)

I can't exactly reproduce when Proton returns uppercase SHA1, but it seems that if we set all SHA1 to lower case it should unify the way it's handled later in Rclone: https://github.com/rclone/rclone/blob/c5ff5afc21e818835e953eb424c8744daa1eb49e/fs/operations/operations.go#L119

@tomekit tomekit mentioned this pull request May 5, 2024
@ncw
Copy link

ncw commented Sep 18, 2024

You could instead / as well fix this in rclone @tomekit

https://github.com/rclone/rclone/blob/1a9e6a527d0f13f4fc047a67570a4a943fdd16bb/backend/protondrive/protondrive.go#L849

@henrybear327 would you consider adding me as a maintainer for this repo and henrybear327/go-proton-api then I can merge obviously correct stuff like this when you don't have time?

Or you might want to consider transferring both the repos into the rclone organization? Then any of the rclone maintainers can help out. Drop me an email [email protected] if you want to discuss more.

@henrybear327
Copy link
Owner

You could instead / as well fix this in rclone @tomekit

https://github.com/rclone/rclone/blob/1a9e6a527d0f13f4fc047a67570a4a943fdd16bb/backend/protondrive/protondrive.go#L849

@henrybear327 would you consider adding me as a maintainer for this repo and henrybear327/go-proton-api then I can merge obviously correct stuff like this when you don't have time?

Or you might want to consider transferring both the repos into the rclone organization? Then any of the rclone maintainers can help out. Drop me an email [email protected] if you want to discuss more.

Hey @ncw,

I have dropped you an email :)

Have a nice weekend!

Henry

@henrybear327 henrybear327 changed the title Address SHA1 case issue. https://github.com/henrybear327/Proton-API-B… Address SHA1 case issue Sep 22, 2024
@henrybear327 henrybear327 merged commit 2172bb8 into henrybear327:master Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants