feat: add oci format chart support #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reegnz
reviewed
Sep 19, 2023
yxxhero
force-pushed
the
add-oci-format-chart-supporting
branch
from
1a65dd4
to
e568fd5
Compare
|
@mumoshu could I get your reivew? Thanks so much. |
mumoshu
reviewed
Aug 28, 2024
chartify.go
Outdated
| @@ -692,16 +693,36 @@ func (r *Runner) copyToTempDir(path, tempDir, chartVersion string) (string, erro | |||
| } | |||
|
|
|||
| func (r *Runner) fetchAndUntarUnderDir(chart, tempDir, chartVersion string) (string, error) { | |||
| command := []string{"fetch", chart, "--untar", "-d", tempDir} | |||
| ociEnv := map[string]string{ | |||
| "HELM_EXPERIMENTAL_OCI": "1", | |||
There was a problem hiding this comment.
To be clear, we don't need this anymore, since helm 3.8?
|
Will this be merged? I've encountered a weird issue with using Azure Container Registry as an OCI repo. Getting an error like ".../chartify999/.../foo/ is a directory". |
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
yxxhero
force-pushed
the
add-oci-format-chart-supporting
branch
from
4df399d
to
49f3047
Compare
Signed-off-by: yxxhero <[email protected]>
Signed-off-by: yxxhero <[email protected]>
|
@mumoshu please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
helmfile/helmfile#928