feat: Adding template arguments #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KATechDev
force-pushed
the
feat/add-template-arguments
branch
from
fd63118
to
af1a31f
Compare
|
can you please fix the linting errors & the test |
KATechDev
force-pushed
the
feat/add-template-arguments
branch
from
af1a31f
to
6dacf91
Compare
|
@KATechDev plaese fix DCO. |
Signed-off-by: Kerstin Albers <[email protected]>
KATechDev
force-pushed
the
feat/add-template-arguments
branch
from
fff6248
to
e84419e
Compare
|
fixed DCO and adjusted test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
TemplateArgsto allow passing any args to the helm template function.I use this to pass
--dry-run=serverfor helmfile apply (which is using helm template underneath) . This enables me to use thelookupfunctionality in my helm charts.helmfile PR is already prepared and will follow.