Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP for setting AppVersion during install/upgrade #315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jasondamour
Copy link

No description provided.

Signed-off-by: Jason D'Amour <[email protected]>
@jasondamour
Copy link
Author

@bacongobbler Mind reviewing this? This is a simple safe, backwards-compatible change as proposed

@jasondamour
Copy link
Author

🙃

@elonmallin
Copy link

I like the idea of this. The use-case I'm thinking of is having a base chart that many of my apps use but I just need to override the image, tag and some env vars to deploy a completely different app. But for it to make sense the appVersion should also update as the PR mentions.

I have a question though. Is it bad in some way since the chart version won't be updated if we do this? If you create a new chart with helm create it will add this to the Chart.yaml:

# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.1.3

This explicitly says that if appVersion is updated the version should be updated as well so following this recommendation it would never be possible to have the same version for different appVersions like in this PR.

I don't see why this would matter but I'm too unfamiliar with Helm to know for sure. Does someone know if the comment is valid for some reason or if it's ok to ignore it in the case of doing helm install/update like the use case in the PR?

@jasondamour
Copy link
Author

@elonmallin it is extremely common to version a chart separately than an application. They are two logically isolated entities, and each can change without the other!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants