-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update askpass.py user interface #63
base: master
Are you sure you want to change the base?
Conversation
Thanks @wjk. Since helloSystem now has Also, let's avoid untranslated English-only text wherever possible, pending #46 (comment). Until we have found an easy way to manage translations for PyQt applications, I think "Password: _____" is better than "(Long English-only text): _____"- |
I created multiple copies of I would also like to invite your attention to the babel package. Among other useful tools, this package includes a pure-Python |
If this works with halfway reasonable code size and runtime performance overhead, then this would rock 👍 So I would highly appreciate a proof-of-concept.
"... that are not part of the base system". So this one is a close call, and I am still a bit undecided myself. It depends on whether we think that anyone outside of helloSystem will want to use those applications. |
According to the “Note to distributors” page in your documentation, these apps are not intended to be used outside of helloSystem as-is. Therefore, the askpass script can indeed be assumed to be part of the base system. I will therefore remove the local copies. I will submit my gettext POC in another branch. Thanks! |
Agree that we should treat askpass as being part of the base system. However I think we should not hardcode the path but rely on |
@probonopd I can certainly inherit the value for |
We could
|
This PR does two things:
askpass.py
to the version from the version in the ISO repo, albeit with one change: a colon is now present after “Password”.SUDO_ASKPASS_TEXT
.