Add check spelling #180
Add check spelling #180
Conversation
|
|
|
Hello @jsoref can you please send a PR againt the |
* spelling: acquired Signed-off-by: Josh Soref <[email protected]> * spelling: application Signed-off-by: Josh Soref <[email protected]> * spelling: async Signed-off-by: Josh Soref <[email protected]> * spelling: better Signed-off-by: Josh Soref <[email protected]> * spelling: close Signed-off-by: Josh Soref <[email protected]> * spelling: documented Signed-off-by: Josh Soref <[email protected]> * spelling: implements Signed-off-by: Josh Soref <[email protected]> * spelling: independent Signed-off-by: Josh Soref <[email protected]> * spelling: maximize Signed-off-by: Josh Soref <[email protected]> * spelling: received Signed-off-by: Josh Soref <[email protected]> * spelling: switch Signed-off-by: Josh Soref <[email protected]> * spelling: transient Signed-off-by: Josh Soref <[email protected]> * spelling: triggered Signed-off-by: Josh Soref <[email protected]> * spelling: unsightly Signed-off-by: Josh Soref <[email protected]> --------- Signed-off-by: Josh Soref <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: probonopd <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
force-pushed
the
add-check-spelling
branch
from
72d3dec to
27927f2
Compare
| pkg_check_modules(QCALCULATE REQUIRED libqalculate) | ||
| pkg_check_modules(QALCULATE REQUIRED libqalculate) |
There was a problem hiding this comment.
this of course isn't required, but it seemed reasonable to use the same spelling as the module
| for (QAction *findActivateeCanidcate : m_searchMenu->actions()) | ||
| if (!findActivateeCanidcate->isSeparator()) { | ||
| m_searchMenu->setActiveAction(findActivateeCanidcate); | ||
| for (QAction *findCandidateAction : m_searchMenu->actions()) | ||
| if (!findCandidateAction->isSeparator()) { | ||
| m_searchMenu->setActiveAction(findCandidateAction); |
There was a problem hiding this comment.
this was a manual change of sorts. There were two tokens in this variable that weren't in the dictionary, it seemed to make sense to avoid the word Active as findActive could be confusing -- given the short scope, I opted to drop the token entirely in favor of action (I contemplated menuitem but I wasn't certain it was always going to be a menuitem, so I went with the type).
There was a problem hiding this comment.
You should look over this file at least once, as items here will be treated as part of the dictionary, so it'd be bad if a misspelled item were included.
Most of the items that I've included here were used in file paths -- check-spelling wanted to identify a misspelled filename, but it wouldn't do that if it decided that filenames aren't usually dictionary words, so including items was necessary to shift the balance from "mostly not dictionary words" to "mostly dictionary words".
| extensionwidget | ||
| github | ||
| https | ||
| kde |
There was a problem hiding this comment.
note that unlike expect, an entry here doesn't cover other case variants (so, KDE will likely be in expect.txt -- it could be moved here).
| \.zip$ | ||
| ^\.github/actions/spelling/ | ||
| ^\Q.github/workflows/spelling.yml\E$ | ||
| ^\Qplugin-statusnotifier/statusnotifier.cpp\E$ |
There was a problem hiding this comment.
I retained this from earlier runs, but notably, Statusnotifier in this file might be better written as StatusNotifier -- I opted not to think about that because I should be sleeping.
| ^\Qplugin-statusnotifier/statusnotifier.cpp\E$ | ||
| ^\Qplugin-statusnotifier/statusnotifier.json\E$ | ||
| ^\Qsrc/lineediteventfilter.cpp\E$ | ||
| _(?!en)..(?:_\w+|)\.ts$ |
There was a problem hiding this comment.
this line is designed to skip all translation files that aren't the English translation files. I wrote it for the original PR, and a spot check seems to indicate it did the right thing. (This version of check-spelling will tell you which files it's checking in the log, so you can check its work...)
There was a problem hiding this comment.
As with allow.txt, it's worth reading this file over to make sure there aren't any surprises. I've done a bunch of passes, so I think the list is reasonable, but it's late, so I could have made a mistake...
| GITHUB_TOKEN: .*$ | ||
|
|
||
| # IServiceProvider / isAThing | ||
| (?:(?<=[a-z])|\b)(?:[IQ]|isA)(?=(?:[A-Z][a-z]{2,})+(?:[^a-z]|\b)) | ||
|
|
||
| # libraries | ||
| libx | ||
| \blib(?=[a-qs-yz]) | ||
|
|
||
| LIVEstep | ||
|
|
||
| # subsidiaries | ||
| \(-ies\) |
There was a problem hiding this comment.
These are custom entries specific to this repository (the items preceding came from candidates from spell-check-this and the items following came from patterns).
|
Thank you very much for your dedciation @jsoref. I truly appreciate it 👍 |
Per #78 (comment)
note that check-spelling has gotten a bit smarter since the previous PR.
Here,
any more.)