Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New onboarding #839

Merged
merged 5 commits into from
Dec 12, 2024
Merged

New onboarding #839

merged 5 commits into from
Dec 12, 2024

Conversation

Perronef5
Copy link
Contributor

@Perronef5 Perronef5 commented Dec 7, 2024 •
edited
Loading

CHANGES 📲

  • Add New Onboarding UI for a fresh account with no wallets
  • Add new navigator for onboarding new wallets
  • Add new splash screen

DEMO 📷

helium.mp4
Simulator.Screen.Recording.-.iPhone.15.-.2024-12-07.at.19.40.30.mp4

@Perronef5 Perronef5 requested a review from a team as a code owner December 7, 2024 23:46
@Perronef5 Perronef5 requested review from allenan and tyler-whitman and removed request for a team December 7, 2024 23:46
marcialc
marcialc reviewed Dec 8, 2024
View reviewed changes
Copy link

@marcialc marcialc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@ChewingGlass ChewingGlass self-requested a review December 9, 2024 16:45
ChewingGlass
ChewingGlass requested changes Dec 9, 2024
View reviewed changes
src/config/locales/en.ts Outdated Show resolved Hide resolved
src/features/accounts/WalletList.tsx Show resolved Hide resolved
src/features/accounts/WalletList.tsx Outdated Show resolved Hide resolved
src/features/accounts/WalletList.tsx Outdated Show resolved Hide resolved
src/features/accounts/WalletList.tsx Outdated Show resolved Hide resolved
src/features/ledger/DeviceScan.tsx Outdated Show resolved Hide resolved
src/features/ledger/getDeviceAnimation.ts Show resolved Hide resolved
src/features/onboarding/AccountAssignScreen.tsx Show resolved Hide resolved
src/features/onboarding/AccountAssignScreen.tsx Show resolved Hide resolved
@Perronef5 Perronef5 merged commit cbdc085 into main Dec 12, 2024
2 checks passed
@Perronef5 Perronef5 deleted the new-onboarding branch December 12, 2024 05:43
@Perronef5 Perronef5 linked an issue Dec 12, 2024 that may be closed by this pull request
Update app onboarding UI #829
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcialc marcialc marcialc left review comments

@ChewingGlass ChewingGlass ChewingGlass approved these changes

@bryzettler bryzettler bryzettler approved these changes

@allenan allenan Awaiting requested review from allenan allenan is a code owner automatically assigned from helium/app-team

@tyler-whitman tyler-whitman Awaiting requested review from tyler-whitman tyler-whitman is a code owner automatically assigned from helium/app-team

Assignees

@Perronef5 Perronef5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update app onboarding UI
4 participants
@Perronef5 @bryzettler @marcialc @ChewingGlass