Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom tracing b58 printing #823

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix custom tracing b58 printing #823

merged 2 commits into from
Jun 7, 2024

Conversation

macpie
Copy link
Member

@macpie macpie commented Jun 4, 2024

No description provided.

madninja
madninja reviewed Jun 4, 2024
View reviewed changes
custom_tracing/Cargo.toml Outdated Show resolved Hide resolved
custom_tracing/src/lib.rs Show resolved Hide resolved
@michaeldjeffrey
Copy link
Contributor

Can we get a description of why this was the wrong way to print a b58?

@madninja
Copy link
Member

madninja commented Jun 7, 2024

Can we get a description of why this was the wrong way to print a b58?

in helium crypto we use b58 check encoding (with a version 0 prefix) not a plain b58 encoding

@macpie macpie merged commit 315cb85 into main Jun 7, 2024
15 checks passed
@macpie macpie deleted the macpie/fix_custom_tracing_b58 branch June 7, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madninja madninja madninja left review comments

@michaeldjeffrey michaeldjeffrey michaeldjeffrey approved these changes

@bbalser bbalser bbalser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@macpie @michaeldjeffrey @madninja @bbalser