Check the chain for transactions if there are attempted burns that haven't been completed #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplant
changed the title
maplant
changed the title
maplant
changed the title
andymck
reviewed
Aug 18, 2023
andymck
reviewed
Aug 18, 2023
|
looks like the testing trait implementations may be missing some of the new methods |
maplant
changed the title
andymck
reviewed
Aug 22, 2023
| @@ -65,6 +65,7 @@ hextree = "*" | |||
| solana-client = "1.14" | |||
| solana-sdk = "1.14" | |||
| solana-program = "1.11" | |||
| solana-transaction-status = "1.14" | |||
There was a problem hiding this comment.
friendly periodic reminder that the solana family of dependencies is in the 1.16.x range now. we'll have to struggle through an update eventually
jeffgrunewald
approved these changes
Aug 24, 2023
andymck
reviewed
Aug 25, 2023
| @@ -48,25 +59,62 @@ impl PendingBurns for Pool<Postgres> { | |||
| .await | |||
| } | |||
|
|
|||
| async fn subtract_burned_amount( | |||
| async fn fetch_incomplete_burns(&mut self) -> Result<Vec<BurnAttempt>, Self::Error> { | |||
| sqlx::query_as("SELECT * FROM attempted_burns") | |||
There was a problem hiding this comment.
you forget to checkin the migration for this table ?
andymck
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.