bubble up route uuid parse errors to user #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldjeffrey
approved these changes
Aug 15, 2023
andymck
approved these changes
Aug 16, 2023
bbalser
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternative to #597 to expose the route id uuid parsing error to the user when it occurs instead of swallowing it in a less descriptive "auth error".
my basic approach to returning errors to the caller of a public-facing API is to provide as few details as possible for an attacker to exploit and then slowly add more details to make the system usable for the normal good operators just trying to use the system as designed, hence the large default reliance on "not much to see here". i think this is definitely a case where providing the detail of a typoed or invalid UUID format is reasonable detail to return to the user.