This repository has been archived by the owner on Jun 12, 2023. It is now read-only.
Increase validator max tcp connections #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in consensus group, validators seem to hit up against the default max tcp connection limit of 1024. This PR updates the default configuration for validators to increase the max to 2048.
The screen shot below shows a validator in CG for 6 rounds. Connections grow over time until they are clipped at 1024 around the 3rd or 4th round. I have observed this on multiple validators and multiple CG tenures. This may be exacerbated by helium/erlang-libp2p#419.