Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README with some "how to run this correctly" instructions #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamiew
Copy link
Contributor

@jamiew jamiew commented Jun 29, 2022

What is correct setup procedure for READ_ONLY_REDIS_URL? Used for the vote data on closed votes

App works fine otherwise

Maybe add some nodejs engines or other best practices

cc @jthiller

@jthiller
Copy link
Collaborator

I think there is something specific to your config/install of yarn. I get no complaints of redis and this branch runs fine without the env file.

Let's pull that part and should be good to go.

Typically I run npm run dev to skirt the linting errors... probably why there are so many of them.

@jamiew
Copy link
Contributor Author

jamiew commented Jun 30, 2022

App works fine unless you go to Closed tab, which hits these API pages which error out

Offhand looks like there are 3 ENV vars:

READ_ONLY_REDIS_URL
REDIS_URL
API_URL

but only READ_ONLY_REDIS_URL is required, the other two have defaults

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants