Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map backend #12 - added a map to store default in backend #52

Closed
wants to merge 4 commits into from
Closed

Map backend #12 - added a map to store default in backend #52

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f5d6065
Added a map to store default config values
Jan 10, 2019
494e937
Added Default method to stores in contra_test.go
Jan 10, 2019
5ab64f7
Removed Default function
Jan 10, 2019
7cf9648
FIXED typo in comment
zelahi Feb 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,15 @@ func Func(name string, fn func(context.Context, string) ([]byte, error)) Backend
return &backendFunc{fn: fn, name: name}
}

// FuncWithDefaults creates a Backend from a function and allows users to add a default map.
func FuncWithDefaults(name string, defaults map[string]string, fn func(context.Context, string) ([]byte, error)) Backend {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what this is doing. The defaults value here is never used.

return &backendFunc{fn: fn, name: name, defaults: defaults}
}

type backendFunc struct {
fn func(context.Context, string) ([]byte, error)
name string
defaults map[string]string
}

func (b *backendFunc) Get(ctx context.Context, key string) ([]byte, error) {
Expand Down