Allow to omit icons at the start of important output lines

[sol]

This is part of #522.

[moodmosaic]

Very nice 👍

This will make MinGW 32/64 users happier, including myself (occasionally) 💕

[sol]

This will make MinGW 32/64 users happier, including myself (occasionally) 💕

Happy if it helps. Beware, however, that Hedgehog will still produce non-ASCII characters. This only removes the icons at the beginning of the lines, as they don't add much for Hspec.

I think a proper solution for MingGW would be to use replacement characters from the ASCII range when the handle does not support UTF-8.

1. https://github.com/hspec/hspec/blob/30ba7ed0b75d802960931fcd1e0a001041084c55/hspec-core/src/Test/Hspec/Core/Runner.hs#L525
2. https://github.com/hspec/hspec/blob/main/hspec-core/src/Test/Hspec/Core/Formatters/V2.hs#L184

[moodmosaic]

Hmm, now that #523 is merged, this needs to be rebased.

[moodmosaic]

This will make MinGW 32/64 users happier, including myself (occasionally) 💕

Happy if it helps. Beware, however, that Hedgehog will still produce non-ASCII characters. This only removes the icons at the beginning of the lines, as they don't add much for Hspec.

I think a proper solution for MingGW would be to use replacement characters from the ASCII range when the handle does not support UTF-8.

1. https://github.com/hspec/hspec/blob/30ba7ed0b75d802960931fcd1e0a001041084c55/hspec-core/src/Test/Hspec/Core/Runner.hs#L525
2. https://github.com/hspec/hspec/blob/main/hspec-core/src/Test/Hspec/Core/Formatters/V2.hs#L184

Thanks for the links 👍 Yes, this is more or less what I had in mind. 🙌

[moodmosaic]

Hmm, now that #523 is merged, this needs to be rebased.

@sol, done. I rebased from the command-line and force-pushed, hope that's OK for you. The conflict was this, due to #523:

defaultConfig :: Config
<<<<<<< HEAD
defaultConfig = Config FullContext True True
=======
defaultConfig = Config FullContext True EnablePrefixIcons
>>>>>>> 17ece22 (Allow to omit icons at the start of important output lines)

Please have a look and if all looks good we can merge. 🎉

[sol]

@moodmosaic yes, all good 👍 Thanks a lot 🙏