Fix "insufficient coverage" message #521
Conversation
- Fix a typo - Remove redundant `TestCount`
| @@ -323,7 +323,7 @@ checkReport cfg size0 seed0 test0 updateUI = do | |||
| successReport | |||
| else | |||
| failureReport $ | |||
| "Labels not sufficently covered after " <> show tests <> " tests" | |||
| "Labels not sufficiently covered after " <> show tests <> " tests" | |||
There was a problem hiding this comment.
before: Labels not sufficently covered after TestCount 100 tests
after: Labels not sufficiently covered after 100 tests
|
|
||
| instance Show TestCount where | ||
| showsPrec p (TestCount n) = | ||
| showsPrec p n |
There was a problem hiding this comment.
- We probably would want this for the other newtypes around
Intas well. - Are ok with dropping support for GHC
8.0.*? If yes, I can simplify this to:deriving Lift deriving newtype (Eq, Ord, Show, Num, Enum, Real, Integral)
There was a problem hiding this comment.
Good catch on Show 👍
How about planning for a release this month, and after doing the release drop support for GHC 8.0.*?
There was a problem hiding this comment.
Regarding GHC 8.0.*, anything works for me. If we are not ready to drop support now, then I guess we want that code as this. So from my perspective, this is ready to merge.
Regarding Show instances of other newtype wraps, we might still want to add the manual instances or wait for after the release. Again, both works for me, but if now, I would do it as a separate PR.
There was a problem hiding this comment.
Perhaps, the best would be to merge this as-is, add Show instances of other newtypes as separate PRs if needed, and drop GHC 8.0.* after this release. If you agree, I think we can merge this as-is.
|
|
||
| instance Show TestCount where | ||
| showsPrec p (TestCount n) = | ||
| showsPrec p n |
There was a problem hiding this comment.
Good catch on Show 👍
How about planning for a release this month, and after doing the release drop support for GHC 8.0.*?
| @@ -323,7 +323,7 @@ checkReport cfg size0 seed0 test0 updateUI = do | |||
| successReport | |||
| else | |||
| failureReport $ | |||
| "Labels not sufficently covered after " <> show tests <> " tests" | |||
| "Labels not sufficiently covered after " <> show tests <> " tests" | |||
|
Thank you @sol 🙏 |
|
Thanks @moodmosaic 🙏 |
TestCount