Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support empty property names #520

Merged
merged 1 commit into from
May 4, 2024

Conversation

sol
Copy link
Contributor

@sol sol commented May 3, 2024

No description provided.

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually empty names were used inside GHCi sessions so it would always make sense to show <interactive> and of course your changes make sense 👍 Is the use case coming from hspec?

@sol
Copy link
Contributor Author

sol commented May 3, 2024

Is the use case coming from hspec?

Yes, the test name doesn't really add anything in the context of Hspec. Right now I'm passing in Just "property", but again, it doesn't really add anything, and all the output is just as meaningful when I use Just "" instead (modulo that extra whitespace, which this PR addresses).

@moodmosaic
Copy link
Member

💯

@moodmosaic moodmosaic merged commit 707e853 into hedgehogqa:master May 4, 2024
25 checks passed
@sol sol deleted the empty-property-names branch May 4, 2024 08:49
@sol sol changed the title Hedgehog.Internal.Report: Support empty property names Support empty property names May 4, 2024
@sol
Copy link
Contributor Author

sol commented May 4, 2024

Thanks for merging 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants