Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow GHC 9.8 #504

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Allow GHC 9.8 #504

merged 1 commit into from
Oct 16, 2023

Conversation

tomjaguarpaw
Copy link
Contributor

Fixed version of #503

Thanks to @ysangkok for most of the work here!

@tomjaguarpaw
Copy link
Contributor Author

Clearly not yet fixed, working on it!

@tomjaguarpaw
Copy link
Contributor Author

The difference between this and #503 is that this one puts the warning disablement in the top-level cabal.project. I guess that's where it needs to be to be picked up correctly.

@tomjaguarpaw
Copy link
Contributor Author

OK, fixed now.

@tomjaguarpaw tomjaguarpaw mentioned this pull request Oct 16, 2023
@ysangkok
Copy link
Contributor

ysangkok commented Oct 16, 2023

Ah thanks, this seems better since it avoids adding the new file. Though I don't actually understand why it would abort compilation, since I don't see -Werror anywhere and surely that wouldn't be the default.

EDIT: Hmm, of course I do see it now, dunno how I could have missed it

Copy link
Member

@moodmosaic moodmosaic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@moodmosaic
Copy link
Member

Thank you, @ysangkok and @tomjaguarpaw 👍

@moodmosaic moodmosaic merged commit 52c35ca into hedgehogqa:master Oct 16, 2023
25 checks passed
@tomjaguarpaw tomjaguarpaw deleted the 9.8 branch October 17, 2023 07:26
@tomjaguarpaw
Copy link
Contributor Author

Thanks! Could you also please make a Hackage release, otherwise we can't use it :)

@moodmosaic
Copy link
Member

Of course 👍 It’s planned for this week.

@moodmosaic
Copy link
Member

Published new revision for hedgehog-1.4 as per #502 (comment) 🦔

@tomjaguarpaw
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants