Skip to content

Commit

Permalink
Merge pull request #2 from headsnet/remove-gitlab-linting
Browse files Browse the repository at this point in the history
Remove Gitlab Linting as it is problematic
  • Loading branch information
benr77 authored Jun 2, 2024
2 parents d843933 + 67cc0c8 commit 40bd4d4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
4 changes: 3 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,11 @@
"minimum-stability": "stable",
"require": {
"phpro/grumphp": "^2.5",
"headsnet/grumphp-gitlab-lint": "^0.1.0",
"ergebnis/composer-normalize": "^2.2"
},
"suggest": {
"headsnet/grumphp-gitlab-lint": "^0.1.0"
},
"config": {
"allow-plugins": {
"phpro/grumphp": true,
Expand Down
11 changes: 0 additions & 11 deletions grumphp.conventions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ parameters:
convention.git_blacklist.keywords: [ 'die\\(', 'dd\\(', 'dump\\(', 'var_dump\\(', 'exit;' ]
convention.git_branch_name.blacklist: [ master, main ]
convention.git_branch_name.whitelist: [ ]
convention.gitlab_lint.api_token: 'MY TOKEN'
convention.gitlab_lint.gitlab_url: 'gitlab.com/api/v4/projects/:id'
convention.gitlab_lint.gitlab_file: '.gitlab-ci.yml'
convention.doctrine_schema_check.command: './bin/console doctrine:schema:validate --skip-sync'
convention.lint_twig.command: './bin/console lint:twig templates'
convention.lint_yaml.command: './bin/console lint:yaml --parse-tags src config tests translations'
Expand Down Expand Up @@ -39,10 +36,6 @@ grumphp:
git_commit_message:
max_subject_width: 72 # The old-school convention of 65 characters is way too limited
max_body_width: 72
gitlab_lint:
api_token: '%convention.gitlab_lint.api_token%'
gitlab_url: '%convention.gitlab_lint.gitlab_url%'
gitlab_file: '%convention.gitlab_lint.gitlab_file%'
lint_twig:
scripts: [["-c", '%convention.lint_twig.command%']]
triggered_by: [ twig ]
Expand All @@ -63,9 +56,6 @@ grumphp:
testsuite: Unit,Integration
metadata: { task: paratest }

extensions:
- Headsnet\GrumPHP\GitlabLint\Loader

testsuites:
git_commit_msg:
tasks:
Expand All @@ -81,7 +71,6 @@ grumphp:
- composer_normalize
- lint_twig
- lint_yaml
- gitlab_lint
my_pre_push:
tasks:
- phpunit_all
Expand Down

0 comments on commit 40bd4d4

Please sign in to comment.