Refresh StoredEvent object and confirm still unpublished #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In extremely high concurrency situations, it was possible for the entities loaded in `PublishDomainEventSubscriber::publishEvents()` to be published by another process, before the subsequent lock was acquired. This commit enables a Doctrine "refresh" of the entity, inside the lock, which then allows us to perform a reliable lookup of the entity's published status, and then only publish if it is still unpublished.
benr77
force-pushed
the
fix-concurrency-problems
branch
from
1147ceb to
9f2eee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In extremely high concurrency situations, it was possible for the entities loaded in
PublishDomainEventSubscriber::publishEvents()to be published by another process, before the subsequent lock was acquired.This commit enables a Doctrine "refresh" of the entity, inside the lock, which then allows us to perform a reliable lookup of the entity's published status, and then only publish if it is still unpublished.