Fix blocking in SizedQueue#push

headius · Jan 3, 2024 · a1ab000 · a1ab000
1 parent 4278f07
commit a1ab000
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/core/src/main/java/org/jruby/ext/thread/SizedQueue.java b/core/src/main/java/org/jruby/ext/thread/SizedQueue.java
@@ -148,7 +148,11 @@ public IRubyObject push(ThreadContext context, final IRubyObject arg0, final IRu
         boolean should_block = arg1.isTrue();
 
         try {
-            return context.getThread().executeTaskBlocking(context, arg0, should_block ? blockingPushTask : nonblockingPushTask);
+            if (should_block) {
+                return context.getThread().executeTaskBlocking(context, arg0, blockingPushTask);
+            }
+
+            return context.getThread().executeTask(context, arg0, nonblockingPushTask);
         } catch (InterruptedException ie) {
             throw createInterruptedError(context, "push");
         }