-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Python 3.8 and add Python 3.13 #240
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #240 +/- ##
==========================================
+ Coverage 86.65% 86.73% +0.08%
==========================================
Files 5 5
Lines 1206 1206
Branches 304 229 -75
==========================================
+ Hits 1045 1046 +1
Misses 102 102
+ Partials 59 58 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Parallel write tests are failing on Windows with Python 3.13. Not sure why. I also ran all tests on this branch to see if it is only Python 3.13: https://github.com/hdmf-dev/hdmf-zarr/actions/runs/11968032434 If it is only Python 3.13 and there is no easy fix, I propose, in the interest of our schedules, that we remove python 3.13 support (just remove the line from |
@rly If I understand what you are saying, keep the testing with 3.13 but remove support for 3.13 for users via pyproject.toml. To do that I think we have add a <3.13, not just comment out the classifier part. I believe that is just metadata. |
The Windows Python 3.13 error was fixed in pytest 8.1.0: pytest-dev/pytest#11875 I think updating pytest and related dependencies should resolve the error (I just pushed changes for that to this branch). We should update all the fixed testing dependencies before the 1.0 release anyway. |
Remove Python 3.8 and add Python 3.13
Fix #234
Checklist
ruff
from the source directory.