Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.8 and add Python 3.13 #240

Merged
merged 29 commits into from
Nov 23, 2024
Merged

Remove Python 3.8 and add Python 3.13 #240

merged 29 commits into from
Nov 23, 2024

Conversation

mavaylon1
Copy link
Contributor

@mavaylon1 mavaylon1 commented Nov 22, 2024

Remove Python 3.8 and add Python 3.13
Fix #234

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running ruff from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.73%. Comparing base (6fd9d53) to head (d1face9).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #240      +/-   ##
==========================================
+ Coverage   86.65%   86.73%   +0.08%     
==========================================
  Files           5        5              
  Lines        1206     1206              
  Branches      304      229      -75     
==========================================
+ Hits         1045     1046       +1     
  Misses        102      102              
+ Partials       59       58       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mavaylon1 mavaylon1 marked this pull request as ready for review November 22, 2024 06:24
@mavaylon1 mavaylon1 requested a review from rly November 22, 2024 06:29
@rly
Copy link
Contributor

rly commented Nov 22, 2024

Parallel write tests are failing on Windows with Python 3.13. Not sure why. I also ran all tests on this branch to see if it is only Python 3.13: https://github.com/hdmf-dev/hdmf-zarr/actions/runs/11968032434

If it is only Python 3.13 and there is no easy fix, I propose, in the interest of our schedules, that we remove python 3.13 support (just remove the line from pyproject.toml) for now, and we can add it in a later version of hdmf-zarr. We can keep the tests and CI as they are while we work through the issue.

@mavaylon1
Copy link
Contributor Author

@rly If I understand what you are saying, keep the testing with 3.13 but remove support for 3.13 for users via pyproject.toml. To do that I think we have add a <3.13, not just comment out the classifier part. I believe that is just metadata.

@rly
Copy link
Contributor

rly commented Nov 22, 2024

The Windows Python 3.13 error was fixed in pytest 8.1.0: pytest-dev/pytest#11875

I think updating pytest and related dependencies should resolve the error (I just pushed changes for that to this branch). We should update all the fixed testing dependencies before the 1.0 release anyway.

@mavaylon1 mavaylon1 enabled auto-merge (squash) November 23, 2024 00:17
@mavaylon1 mavaylon1 merged commit 3d08b60 into dev Nov 23, 2024
23 checks passed
@mavaylon1 mavaylon1 deleted the python39 branch November 23, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Remove support for python 3.8
3 participants