Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Macro and Printing with JuMP 1.18 #110

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Update Macro and Printing with JuMP 1.18 #110

merged 2 commits into from
Feb 7, 2024

Conversation

pulsipher
Copy link
Collaborator

This updates to use the new macro API and to remove the hacking printing fixes that were causing tests to fail.

@pulsipher pulsipher added bug Something isn't working enhancement New feature or request labels Feb 1, 2024
@pulsipher pulsipher self-assigned this Feb 1, 2024
@pulsipher pulsipher mentioned this pull request Feb 1, 2024
9 tasks
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (9ab25ae) 99.90% compared to head (07bc162) 99.12%.

❗ Current head 07bc162 differs from pull request most recent head ca2ae98. Consider uploading reports for the commit ca2ae98 to get more accurate results

Files Patch % Lines
src/macros.jl 83.33% 6 Missing ⚠️
src/print.jl 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   99.90%   99.12%   -0.79%     
==========================================
  Files          11       11              
  Lines        1078     1023      -55     
==========================================
- Hits         1077     1014      -63     
- Misses          1        9       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pulsipher pulsipher requested a review from hdavid16 February 1, 2024 16:45
@pulsipher
Copy link
Collaborator Author

@hdavid16 This is ready to review, the code coverage is false positive since it didn't upload the results of the last run.

Copy link
Owner

@hdavid16 hdavid16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hdavid16 hdavid16 merged commit eb1ce6c into master Feb 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants