Support disjunct constraints with integer variables #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsipher
reviewed
Jan 18, 2024
|
The printing problem can be fixed by updating to use the printing API provided by jump-dev/JuMP.jl#3609. I will open a PR when I can find some extra time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #109 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 11 11
Lines 1021 1021
=======================================
Hits 1019 1019
Misses 2 2 ☔ View full report in Codecov by Sentry. |
pulsipher
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105. Still disallows binary variables in a disjunct constraint. The error message is improved to indicate that the user should rely on Logic variables to model any binary decisions.
Note: @pulsipher, I saw some printing tests failed locally MacOS where
==was being replaced with=and\\iffwas expected instead.